DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: fix compile error for old glibc caused by pthread_setname_np()#
Date: Fri, 20 Nov 2015 12:21:05 +0000	[thread overview]
Message-ID: <20151120122105.GB2528@bricha3-MOBL3> (raw)
In-Reply-To: <1447955066-17131-1-git-send-email-ferruh.yigit@intel.com>

On Thu, Nov 19, 2015 at 05:44:26PM +0000, Ferruh Yigit wrote:
> Fixes: 67b6d3039e9e ("eal: set name to threads")
> 
> pthread_setname_np() function added in glibc 2.12, using this function
> in older glibc versions cause compile error:
> error: implicit declaration of function "pthread_setname_np"
> 
> This patch adds "rte_thread_setname" macro and set it according
> glibc >= 2.12 check, thread naming disabled for older glibc versions,
> glibc versions that support "pthread_setname_np" will keep using this
> function.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  examples/tep_termination/main.c                    | 2 +-
>  examples/vhost/main.c                              | 2 +-
>  examples/vhost_xen/main.c                          | 2 +-
>  lib/librte_eal/common/eal_thread.h                 | 6 ++++++
>  lib/librte_eal/linuxapp/eal/eal.c                  | 2 +-
>  lib/librte_eal/linuxapp/eal/eal_interrupts.c       | 2 +-
>  lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c | 2 +-
>  lib/librte_eal/linuxapp/eal/eal_timer.c            | 2 +-
>  8 files changed, 13 insertions(+), 7 deletions(-)
>
I only see changes to linux files above. Does this not also have an implication
for bsd too?

	/Bruce

  reply	other threads:[~2015-11-20 12:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18 13:32 [dpdk-dev] Compile errors with libc < 2.12 Ferruh Yigit
2015-11-18 14:24 ` Thomas Monjalon
2015-11-19 11:22   ` [dpdk-dev] [PATCH] Revert "eal: set name to threads" Ferruh Yigit
2015-11-19 11:49     ` Panu Matilainen
2015-11-19 12:32       ` Thomas Monjalon
2015-11-19 13:39         ` Ferruh Yigit
2015-11-19 16:59           ` Ferruh Yigit
2015-11-19 17:44             ` [dpdk-dev] [PATCH] eal: fix compile error for old glibc caused by pthread_setname_np() Ferruh Yigit
2015-11-20 12:21               ` Bruce Richardson [this message]
2015-11-24 14:26                 ` [dpdk-dev] [PATCH] eal: fix compile error for old glibc caused by pthread_setname_np()# Ferruh Yigit
2015-11-24 17:54               ` [dpdk-dev] [PATCH] eal: fix compile error for old glibc caused by pthread_setname_np() Thomas Monjalon
2015-11-24 18:47                 ` Ferruh Yigit
2015-11-25 11:13                   ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2015-11-25 11:18                     ` Thomas Monjalon
2015-11-25 11:24                       ` Ferruh Yigit
2015-11-25 11:30                         ` Thomas Monjalon
2015-11-25 13:41                     ` Thomas Monjalon
2015-11-25 13:51                     ` Roger B. Melton
2015-11-25 14:03                       ` Thomas Monjalon
2015-11-25 14:20                         ` Roger B. Melton
2015-11-19 11:23   ` [dpdk-dev] [PATCH] eal: fix compile error for old glibc caused by CLOCK_MONOTONIC_RAW Ferruh Yigit
2015-11-20 17:02     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151120122105.GB2528@bricha3-MOBL3 \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).