From: Stephen Hemminger <stephen@networkplumber.org>
To: Zhihong Wang <zhihong.wang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling
Date: Sun, 22 Nov 2015 18:28:00 -0800 [thread overview]
Message-ID: <20151122182800.397e0701@xeon-e3> (raw)
In-Reply-To: <1448219615-63746-3-git-send-email-zhihong.wang@intel.com>
On Sun, 22 Nov 2015 14:13:35 -0500
Zhihong Wang <zhihong.wang@intel.com> wrote:
> The kernel fills new allocated (huge) pages with zeros.
> DPDK just has to populate page tables to trigger the allocation.
>
> Signed-off-by: Zhihong Wang <zhihong.wang@intel.com>
> ---
> lib/librte_eal/linuxapp/eal/eal_memory.c | 20 ++++++--------------
> 1 file changed, 6 insertions(+), 14 deletions(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c
> index 0de75cd..21a5146 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_memory.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
> @@ -399,8 +399,10 @@ map_all_hugepages(struct hugepage_file *hugepg_tbl,
> return -1;
> }
>
> + /* map the segment, and populate page tables,
> + * the kernel fills this segment with zeros */
> virtaddr = mmap(vma_addr, hugepage_sz, PROT_READ | PROT_WRITE,
> - MAP_SHARED, fd, 0);
> + MAP_SHARED | MAP_POPULATE, fd, 0);
> if (virtaddr == MAP_FAILED) {
> RTE_LOG(ERR, EAL, "%s(): mmap failed: %s\n", __func__,
> strerror(errno));
> @@ -410,7 +412,6 @@ map_all_hugepages(struct hugepage_file *hugepg_tbl,
>
> if (orig) {
> hugepg_tbl[i].orig_va = virtaddr;
> - memset(virtaddr, 0, hugepage_sz);
> }
> else {
> hugepg_tbl[i].final_va = virtaddr;
> @@ -529,22 +530,16 @@ remap_all_hugepages(struct hugepage_file *hugepg_tbl, struct hugepage_info *hpi)
>
> old_addr = vma_addr;
>
> - /* map new, bigger segment */
> + /* map new, bigger segment, and populate page tables,
> + * the kernel fills this segment with zeros */
> vma_addr = mmap(vma_addr, total_size,
> - PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
> + PROT_READ | PROT_WRITE, MAP_SHARED | MAP_POPULATE, fd, 0);
>
> if (vma_addr == MAP_FAILED || vma_addr != old_addr) {
> RTE_LOG(ERR, EAL, "%s(): mmap failed: %s\n", __func__, strerror(errno));
> close(fd);
> return -1;
> }
> -
> - /* touch the page. this is needed because kernel postpones mapping
> - * creation until the first page fault. with this, we pin down
> - * the page and it is marked as used and gets into process' pagemap.
> - */
> - for (offset = 0; offset < total_size; offset += hugepage_sz)
> - *((volatile uint8_t*) RTE_PTR_ADD(vma_addr, offset));
> }
>
> /* set shared flock on the file. */
> @@ -592,9 +587,6 @@ remap_all_hugepages(struct hugepage_file *hugepg_tbl, struct hugepage_info *hpi)
> }
> }
>
> - /* zero out the whole segment */
> - memset(hugepg_tbl[page_idx].final_va, 0, total_size);
> -
> page_idx++;
> }
>
Nice, especially on slow machines or with large memory.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2015-11-23 2:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-22 19:13 [dpdk-dev] [PATCH 0/2] Reduce DPDK initialization time Zhihong Wang
2015-11-22 19:13 ` [dpdk-dev] [PATCH 1/2] lib/librte_eal: Reduce timer " Zhihong Wang
2015-11-22 19:13 ` [dpdk-dev] [PATCH 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling Zhihong Wang
2015-11-23 2:28 ` Stephen Hemminger [this message]
2015-11-24 21:13 ` Thomas Monjalon
2015-11-24 22:44 ` Stephen Hemminger
2015-11-24 23:04 ` Thomas Monjalon
2015-11-25 1:57 ` Yuanhan Liu
2015-11-25 1:59 ` Wang, Zhihong
2016-01-21 14:59 ` [dpdk-dev] [PATCH 0/2] Reduce DPDK initialization time Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151122182800.397e0701@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).