From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] scripts: add git hook scripts for checkpatch and auto doc generation
Date: Tue, 24 Nov 2015 18:04:00 +0000 [thread overview]
Message-ID: <20151124180400.GA15834@sivlogin002.ir.intel.com> (raw)
In-Reply-To: <2076055.LzC464LxxN@xps13>
On Tue, Nov 24, 2015 at 06:44:36PM +0100, Thomas Monjalon wrote:
> Thanks for the idea
>
> 2015-11-06 13:48, Ferruh Yigit:
> > post-merge: Same script as "post-commit", but triggered after git pull
>
> A symbolic link would be sufficient.
> As it must be installed in the git hooks (probably making a symbolic link),
> duplicating the file is not needed at all.
>
OK
> > pre-commit: Does a checkpatch check before commit started. If script
> > finds any error it will print warnings and fails. If checkpatch
> > fails commit also fails. This guaranties every commit pass checkpatch.
> > Default script is <dpdk>/scripts/checkpatch.pl but this can be
> > changed by RTE_CHECKPATCH environment variable. Also a default list
> > of checkpatch ignore items defined, new ones can be added by IGNORE
> > environment variable.
>
> Please use the new scripts/checkpatches.sh:
> http://dpdk.org/dev/patchwork/patch/9036/
>
OK, better to use that script, to prevent duplicated IGNORE flag and checkpatch.pl location maintenance.
> > This script can bypassed by commit "--no-verify" argument.
>
> Could you document the --no-verify option in the script?
>
This is git feature, with that flag script not called at all, I will add this comment into script.
> > Deployment:
> > To make scripts active they need to be in <dpdk>/.git/hooks folder.
> > Alternatively "deploy.sh" script can be used, it simply copies all
> > scripts into proper folder. Script names are significant and
> > shouldn't changed.
>
> Why not using symbolic links?
>
Yes we can use symbolic links.
I will send updated patch.
Thanks for the review,
ferruh
next prev parent reply other threads:[~2015-11-24 18:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 23:22 Ferruh Yigit
2015-11-06 13:48 ` Ferruh Yigit
2015-11-06 13:48 ` Ferruh Yigit
2015-11-24 17:44 ` Thomas Monjalon
2015-11-24 18:04 ` Ferruh Yigit [this message]
2015-11-06 14:03 ` Ferruh Yigit
2015-11-27 14:34 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2015-12-03 19:09 ` Thomas Monjalon
2015-12-07 13:32 ` Ferruh Yigit
2015-12-07 15:06 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124180400.GA15834@sivlogin002.ir.intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).