DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Harish Patil <harish.patil@qlogic.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] bnx2x: tx_start_bd->vlan_or_ethertype is le16
Date: Tue, 1 Dec 2015 14:37:54 -0800	[thread overview]
Message-ID: <20151201143754.06675ca9@xeon-e3> (raw)
In-Reply-To: <D283389F.103FAE%harish.patil@qlogic.com>

On Tue, 1 Dec 2015 21:53:59 +0000
Harish Patil <harish.patil@qlogic.com> wrote:

> >
> >Anyone to review please?
> >
> >2015-11-03 12:26, Chas Williams:  
> >> Signed-off-by: Chas Williams <3chas3@gmail.com>
> >> ---
> >>  drivers/net/bnx2x/bnx2x.c | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
> >> index fed7a06..76444eb 100644
> >> --- a/drivers/net/bnx2x/bnx2x.c
> >> +++ b/drivers/net/bnx2x/bnx2x.c
> >> @@ -2169,7 +2169,8 @@ int bnx2x_tx_encap(struct bnx2x_tx_queue *txq,
> >>struct rte_mbuf **m_head, int m_p
> >>                              struct ether_hdr *eh
> >>                                  = rte_pktmbuf_mtod(m0, struct ether_hdr *);
> >>
> >> -                            tx_start_bd->vlan_or_ethertype = eh->ether_type;
> >> +                            tx_start_bd->vlan_or_ethertype
> >> +                                = rte_cpu_to_le_16(rte_be_to_cpu_16(eh->ether_type));
> >>                      }
> >>              }  
> >
> >  
> 
> Acked-by: Harish Patil <harish.patil@qlogic.com>
> 
> 
> Minor question - any specific reason to use rte_be_to_cpu_16() on
> ether_type alone before converting from native order to le16?

ether_type is in network byte order (big endian)
and hardware wants little endian. On x86 the second step is a nop.

  reply	other threads:[~2015-12-01 22:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 17:26 Chas Williams
2015-11-24 13:42 ` Thomas Monjalon
2015-12-01 21:53   ` Harish Patil
2015-12-01 22:37     ` Stephen Hemminger [this message]
2015-12-01 22:47       ` Harish Patil
2015-12-01 23:34       ` Thomas Monjalon
2015-12-01 23:58         ` Charles (Chas) Williams
2015-12-02  1:04           ` Thomas Monjalon
2015-12-02 10:18             ` Charles (Chas) Williams
2015-12-02 10:44               ` Thomas Monjalon
2015-12-06 21:55     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151201143754.06675ca9@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=harish.patil@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).