From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Jan Viktorin <viktorin@rehivetech.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/3] lpm: add support for NEON
Date: Wed, 2 Dec 2015 20:26:08 +0530 [thread overview]
Message-ID: <20151202145606.GA12696@localhost.localdomain> (raw)
In-Reply-To: <20151202144340.6b846d81@pcviktorin.fit.vutbr.cz>
On Wed, Dec 02, 2015 at 02:43:40PM +0100, Jan Viktorin wrote:
> On Mon, 30 Nov 2015 22:54:12 +0530
> Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote:
>
> > enabled CONFIG_RTE_LIBRTE_LPM, CONFIG_RTE_LIBRTE_TABLE,
> > CONFIG_RTE_LIBRTE_PIPELINE libraries for arm64.
> >
> > TABLE, PIPELINE libraries were disabled due to LPM library dependency.
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> > app/test/test_lpm.c | 10 +-
> > config/defconfig_arm64-armv8a-linuxapp-gcc | 3 -
> > lib/librte_lpm/Makefile | 3 +
> > lib/librte_lpm/rte_lpm.h | 5 +
> > lib/librte_lpm/rte_lpm_neon.h | 172 +++++++++++++++++++++++++++++
> > 5 files changed, 185 insertions(+), 8 deletions(-)
> > create mode 100644 lib/librte_lpm/rte_lpm_neon.h
> >
> > [snip]
> >
> > # this lib needs eal
> > DEPDIRS-$(CONFIG_RTE_LIBRTE_LPM) += lib/librte_eal
> > diff --git a/lib/librte_lpm/rte_lpm.h b/lib/librte_lpm/rte_lpm.h
> > index c299ce2..12b75ce 100644
> > --- a/lib/librte_lpm/rte_lpm.h
> > +++ b/lib/librte_lpm/rte_lpm.h
> > @@ -361,6 +361,9 @@ rte_lpm_lookup_bulk_func(const struct rte_lpm *lpm, const uint32_t * ips,
> > /* Mask four results. */
> > #define RTE_LPM_MASKX4_RES UINT64_C(0x00ff00ff00ff00ff)
> >
> > +#if defined(RTE_ARCH_ARM64)
> > +#include "rte_lpm_neon.h"
> > +#else
> > /**
> > * Lookup four IP addresses in an LPM table.
> > *
> > @@ -473,6 +476,8 @@ rte_lpm_lookupx4(const struct rte_lpm *lpm, __m128i ip, uint16_t hop[4],
> > hop[3] = (tbl[3] & RTE_LPM_LOOKUP_SUCCESS) ? (uint8_t)tbl[3] : defv;
> > }
> >
> > +#endif
> > +
>
> I would separate the SSE implementation into its own file as well.
make sense. planning to make it as lib/librte_lpm/rte_lpm_sse.h
and lib/librte_lpm/rte_lpm_neon.h. OK ?
I can fix it in next revision.
>
> Otherwise, I like this patch. I hope to be able to test it soon.
>
> > [snip]
>
>
> --
> Jan Viktorin E-mail: Viktorin@RehiveTech.com
> System Architect Web: www.RehiveTech.com
> RehiveTech
> Brno, Czech Republic
next prev parent reply other threads:[~2015-12-02 14:56 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 17:24 [dpdk-dev] [PATCH 0/3] add lpm " Jerin Jacob
2015-11-30 17:24 ` [dpdk-dev] [PATCH 1/3] eal: introduce rte_vect_* abstractions Jerin Jacob
2015-12-02 13:43 ` Jan Viktorin
2015-12-02 14:51 ` Jerin Jacob
2015-11-30 17:24 ` [dpdk-dev] [PATCH 2/3] lpm: add support for NEON Jerin Jacob
2015-12-02 13:43 ` Jan Viktorin
2015-12-02 14:56 ` Jerin Jacob [this message]
2015-12-02 15:00 ` Jan Viktorin
2015-11-30 17:24 ` [dpdk-dev] [PATCH 3/3] maintainers: claim responsibility for arm64 specific files of hash and lpm Jerin Jacob
2015-12-02 13:43 ` Jan Viktorin
2015-12-02 14:57 ` Jerin Jacob
2015-12-02 13:43 ` [dpdk-dev] [PATCH 0/3] add lpm support for NEON Jan Viktorin
2015-12-02 14:41 ` Jerin Jacob
2015-12-04 15:14 ` [dpdk-dev] [PATCH v2 " Jerin Jacob
2015-12-04 15:14 ` [dpdk-dev] [PATCH v2 1/3] lpm: make rte_lpm_lookupx4 API definition architecture agnostic Jerin Jacob
2015-12-07 6:15 ` Jianbo Liu
2015-12-07 6:57 ` Jerin Jacob
2015-12-07 14:06 ` Ananyev, Konstantin
2015-12-04 15:14 ` [dpdk-dev] [PATCH v2 2/3] lpm: add support for NEON Jerin Jacob
2015-12-04 15:14 ` [dpdk-dev] [PATCH v2 3/3] maintainers: claim responsibility for arm64 specific files of hash and lpm Jerin Jacob
2016-01-29 4:10 ` [dpdk-dev] [PATCH v3 0/3] add lpm support for NEON Jerin Jacob
2016-01-29 4:10 ` [dpdk-dev] [PATCH v3 1/3] lpm: make rte_lpm_lookupx4 API definition architecture agnostic Jerin Jacob
2016-01-29 4:10 ` [dpdk-dev] [PATCH v3 2/3] lpm: add support for NEON Jerin Jacob
2016-02-11 11:46 ` Thomas Monjalon
2016-02-12 6:47 ` Jerin Jacob
2016-02-12 8:42 ` Thomas Monjalon
2016-01-29 4:10 ` [dpdk-dev] [PATCH v3 3/3] maintainers: claim responsibility for arm64 specific files of hash and lpm Jerin Jacob
2016-02-08 9:29 ` [dpdk-dev] [PATCH v3 0/3] add lpm support for NEON Jerin Jacob
2016-02-12 12:28 ` [dpdk-dev] [PATCH v4 " Jerin Jacob
2016-02-12 12:28 ` [dpdk-dev] [PATCH v4 1/3] lpm: make rte_lpm_lookupx4 API definition architecture agnostic Jerin Jacob
2016-03-01 17:42 ` Thomas Monjalon
2016-03-02 6:28 ` Jerin Jacob
2016-02-12 12:28 ` [dpdk-dev] [PATCH v4 2/3] lpm: add support for NEON Jerin Jacob
2016-03-01 17:46 ` Thomas Monjalon
2016-03-02 6:45 ` Jerin Jacob
2016-02-12 12:28 ` [dpdk-dev] [PATCH v4 3/3] maintainers: claim responsibility for arm64 specific files of hash and lpm Jerin Jacob
2016-03-01 17:47 ` Thomas Monjalon
2016-03-02 6:46 ` Jerin Jacob
2016-02-16 13:27 ` [dpdk-dev] [PATCH v4 0/3] add lpm support for NEON Kobylinski, MichalX
2016-02-16 16:44 ` Jerin Jacob
2016-02-18 10:26 ` Kobylinski, MichalX
2016-02-19 0:34 ` Jerin Jacob
2016-03-11 3:52 ` [dpdk-dev] [PATCH v5 " Jerin Jacob
2016-03-11 3:52 ` [dpdk-dev] [PATCH v5 1/3] lpm: make rte_lpm_lookupx4 API definition architecture agnostic Jerin Jacob
2016-03-11 3:52 ` [dpdk-dev] [PATCH v5 2/3] lpm: add support for NEON Jerin Jacob
2016-03-11 3:52 ` [dpdk-dev] [PATCH v5 3/3] Maintainers: claim responsibility for arm64 specific files of hash Jerin Jacob
2016-03-11 14:24 ` [dpdk-dev] [PATCH v5 0/3] add lpm support for NEON Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202145606.GA12696@localhost.localdomain \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).