From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] mk: fix compile error and ABI versioning for combined shared library
Date: Thu, 3 Dec 2015 11:24:41 +0000 [thread overview]
Message-ID: <20151203112441.GA15978@sivlogin002.ir.intel.com> (raw)
In-Reply-To: <17459798.JpEqoIGKUu@xps13>
On Thu, Dec 03, 2015 at 03:22:39AM +0100, Thomas Monjalon wrote:
> 2015-12-03 02:15, Ferruh Yigit:
> > +ifeq ($(COMBINED_BUILD),1)
> > include $(RTE_SDK)/mk/rte.sharelib.mk
> > +endif
>
> I still don't understand what was the issue with this include but it
> seems not related to versioning.
> Please condider a separate patch with a detailed explanation of the bug.
>
Indeed this is related to the using versioning macros VERSION_SYMBOL, BIND_DEFAULT_SYMBOL
But let me try to fix this in different way
> [...]
> > +FILES=$(find $RTE_SDK -name "*_version.map")
>
> No, we can have several build directories in RTE_SDK.
>
"grep -v" was to remove build output .map files, not searching for _version.map, so it should be OK
but let me narrow search path to lib and drivers folders to be safe
Thanks,
ferruh
next prev parent reply other threads:[~2015-12-03 11:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 1:22 [dpdk-dev] [PATCH v2] " Ferruh Yigit
2015-12-03 1:36 ` Thomas Monjalon
2015-12-03 1:59 ` Ferruh Yigit
2015-12-03 2:15 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2015-12-03 2:22 ` Thomas Monjalon
2015-12-03 11:24 ` Ferruh Yigit [this message]
2015-12-03 8:18 ` [dpdk-dev] [PATCH v2] " Christian Ehrhardt
2015-12-03 11:18 ` Ferruh Yigit
2015-12-03 14:01 ` Ferruh Yigit
2015-12-03 12:49 ` Panu Matilainen
2015-12-03 13:51 ` [dpdk-dev] [PATCH v4] " Ferruh Yigit
2015-12-06 14:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151203112441.GA15978@sivlogin002.ir.intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).