From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mk: fix compile error and ABI versioning for combined shared library
Date: Thu, 3 Dec 2015 14:01:02 +0000 [thread overview]
Message-ID: <20151203140102.GA12729@sivlogin002.ir.intel.com> (raw)
In-Reply-To: <20151203111827.GA11634@sivlogin002.ir.intel.com>
On Thu, Dec 03, 2015 at 11:18:27AM +0000, Ferruh Yigit wrote:
> On Thu, Dec 03, 2015 at 09:18:49AM +0100, Christian Ehrhardt wrote:
> > Hi Ferruh,
> > some minor bash improvements that could be made in the next revision:
> >
> > On Thu, Dec 3, 2015 at 2:22 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> > > diff --git a/scripts/merge_maps.sh b/scripts/merge_maps.sh
> > > new file mode 100755
> > > index 0000000..bc40dc8
> > > --- /dev/null
> > > +++ b/scripts/merge_maps.sh
> > > @@ -0,0 +1,29 @@
> > > +#!/bin/sh
> > > +
> > > +FILES=$(find $RTE_SDK -name "*.map" | grep -v build)
> > > +SYMBOLS=$(grep -h "{" $FILES | sort -u | sed 's/{//')
> >
> > Guarding $RTE_SDK and $FILES with "" will help avoid some potential
> > issues due to words splitting.
I quoted them (not $FILES which grep requires multiple params), but that will not actually help with folder names contains spaces, for that case script is broken.
I fixed script using IFS and a few tricks but made script unnecessarly complex, so I revert back and leaving as it is unless required explicitly.
And I suspect if folder name has spaces this script won't be only thing broken.
Thanks,
ferruh
next prev parent reply other threads:[~2015-12-03 14:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 1:22 Ferruh Yigit
2015-12-03 1:36 ` Thomas Monjalon
2015-12-03 1:59 ` Ferruh Yigit
2015-12-03 2:15 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2015-12-03 2:22 ` Thomas Monjalon
2015-12-03 11:24 ` Ferruh Yigit
2015-12-03 8:18 ` [dpdk-dev] [PATCH v2] " Christian Ehrhardt
2015-12-03 11:18 ` Ferruh Yigit
2015-12-03 14:01 ` Ferruh Yigit [this message]
2015-12-03 12:49 ` Panu Matilainen
2015-12-03 13:51 ` [dpdk-dev] [PATCH v4] " Ferruh Yigit
2015-12-06 14:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151203140102.GA12729@sivlogin002.ir.intel.com \
--to=ferruh.yigit@intel.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).