From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Bernard Iremonger <bernard.iremonger@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples/vhost: reduce number of hugepages needed
Date: Thu, 10 Dec 2015 20:59:11 +0800 [thread overview]
Message-ID: <20151210125911.GV29571@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1449749971-5422-1-git-send-email-bernard.iremonger@intel.com>
On Thu, Dec 10, 2015 at 12:19:31PM +0000, Bernard Iremonger wrote:
> Change MAX_QUEUES to 128 to reduce the number of hugepages required
> by the vhost-switch program.
>
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
> examples/vhost/main.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index b30f1bd..8fb0adb 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -1,7 +1,7 @@
> /*-
> * BSD LICENSE
> *
> - * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> + * Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
> * All rights reserved.
> *
> * Redistribution and use in source and binary forms, with or without
> @@ -53,7 +53,8 @@
>
> #include "main.h"
>
> -#define MAX_QUEUES 512
> +/* decrease MAX_QUEUES from 512 to reduce number of hugepages needed */
Minor nit: I would suggest to simply remove this comment, which might
be a bit confusing without the content (that 512 would let vhost-switch
fail to start if given memory is small).
Otherwise, this patch looks good to me.
Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Thanks.
--yliu
> +#define MAX_QUEUES 128
>
> /* the maximum number of external ports supported */
> #define MAX_SUP_PORTS 1
> --
> 2.6.3
next prev parent reply other threads:[~2015-12-10 12:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 12:19 Bernard Iremonger
2015-12-10 12:59 ` Yuanhan Liu [this message]
2015-12-10 13:26 ` Iremonger, Bernard
2015-12-10 13:34 ` Yuanhan Liu
2015-12-10 13:53 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
2015-12-10 14:50 ` Ananyev, Konstantin
2015-12-10 15:43 ` Iremonger, Bernard
2015-12-11 9:05 ` Panu Matilainen
2015-12-10 15:49 ` [dpdk-dev] [PATCH v3] " Bernard Iremonger
2015-12-10 16:32 ` Ananyev, Konstantin
2015-12-10 21:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210125911.GV29571@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).