From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] virtio: fix virtio_net_hdr desc pointing to the same buffer
Date: Mon, 14 Dec 2015 21:09:31 +0800 [thread overview]
Message-ID: <20151214130931.GD29571@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <2070148.TLndilS6eD@xps13>
On Mon, Dec 14, 2015 at 01:44:54PM +0100, Thomas Monjalon wrote:
> 2015-12-14 19:47, Yuanhan Liu:
> > On Mon, Dec 14, 2015 at 10:32:24AM +0100, Thomas Monjalon wrote:
> > > 2015-12-14 11:01, Yuanhan Liu:
> > > > On Fri, Dec 11, 2015 at 12:07:32AM +0800, Huawei@dpdk.org wrote:
> > > > > The virtio_net_hdr desc all pointed to the same buffer. It doesn't cause
> > > > > issue because in the simple TX mode we don't use the header. This patch
> > > > > makes the header desc point to different buffer.
> > > > >
> > > > > Signed-off-by: Huawei Xie <huawei.xie@intel.com>
> > > >
> > > > Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > >
> > > Does it fix something in the current behaviour?
> >
> > It's more like a logic fixing to me.
> >
> > > I have the feeling it may wait for 2.3.
> >
> > It's been introduced in v2.2, with Huawei's simple tx patchset.
> > Therefore, I guess 2.2 is good to go?
>
> The vhost driver has been validated without with patch.
Huawei stated in the commit log that "It doesn't cause issue because in
the simple TX mode we don't use the header".
> Merging it would be taking the risk of breaking something
> (or just reduce performance) for no clear benefit.
> Am I missing something?
I know your concerns: we really should be cagy about making any changes
when a release is close, especially when all stuff are validated. From
this point of view, I agree with you we could delay it to v2.3.
Maybe huawei have more inputs here?
--yliu
next prev parent reply other threads:[~2015-12-14 13:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 16:07 Huawei
2015-12-12 7:39 ` Tan, Jianfeng
2015-12-14 1:21 ` Xie, Huawei
2015-12-14 1:35 ` Tan, Jianfeng
2015-12-14 3:01 ` Yuanhan Liu
2015-12-14 9:32 ` Thomas Monjalon
2015-12-14 11:47 ` Yuanhan Liu
2015-12-14 12:44 ` Thomas Monjalon
2015-12-14 13:09 ` Yuanhan Liu [this message]
2015-12-14 13:38 ` Xie, Huawei
2015-12-14 13:45 ` Thomas Monjalon
2015-12-14 13:58 ` Xie, Huawei
2016-02-10 15:36 ` Bruce Richardson
2015-12-10 17:57 [dpdk-dev] [PATCH 0/4] vhost: Fix various coverity issues in vhost library Huawei
2015-12-10 17:57 ` [dpdk-dev] [PATCH] virtio: fix virtio_net_hdr desc pointing to the same buffer Huawei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214130931.GD29571@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).