From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: "Andralojc, WojciechX" <wojciechx.andralojc@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Patch introducing API to read/write Intel Architecture Model Specific Registers (MSR), rte_msr_read and rte_msr_write functions.
Date: Wed, 6 Jan 2016 23:03:51 +0530 [thread overview]
Message-ID: <20160106173348.GA23478@localhost.localdomain> (raw)
In-Reply-To: <3FD2C4106EAA5C43838688C653B6E2AFDB8422@IRSMSX103.ger.corp.intel.com>
On Wed, Jan 06, 2016 at 11:47:28AM +0000, Andralojc, WojciechX wrote:
> > From: Andralojc, WojciechX
> > Sent: Thursday, December 17, 2015 12:13 PM
> > To: dev@dpdk.org
> > Cc: Andralojc, WojciechX
> > Subject: [PATCH] Patch introducing API to read/write Intel Architecture Model
> > Specific Registers (MSR), rte_msr_read and rte_msr_write functions.
> >
> > There is work in progress to implement Intel Cache Allocation Technology (CAT)
> > support in DPDK, this technology is programmed through MSRs.
> > In the future it will be possible to program CAT through Linux cgroups and DPDK
> > CAT implementation will take advantage of it.
> >
> > MSR R/W's are privileged ring 0 operations and they must be done in kernel
> > space. For this reason implementation utilizes Linux MSR driver.
> >
> > Signed-off-by: Wojciech Andralojc <wojciechx.andralojc@intel.com>
>
> I've got suggestion offline that as MSRs are IA specific,
> I should not give the dummy APIs for the other arches
> and move MSR access functions into the EAL specific APIs
> or some place more arch specific.
> Do you find submitted MSR patch OK?
> or do you agree with the above feedback and patch should be re-worked?
+1
IMO, No need to expose this function as EAL as other archs can't
implement this.I think, a IA specific function under
lib/librte_eal/common/include/arch/x86/ and removing rte_* from
internal architecture functions looks more appropriate
Jerin
> I am looking forward to your feedback
>
> Thank you!
>
> Wojciech Andralojc
> --------------------------------------------------------------
> Intel Research and Development Ireland Limited
> Registered in Ireland
> Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
> Registered Number: 308263
>
>
> This e-mail and any attachments may contain confidential material for the sole
> use of the intended recipient(s). Any review or distribution by others is
> strictly prohibited. If you are not the intended recipient, please contact the
> sender and delete all copies.
>
next prev parent reply other threads:[~2016-01-06 17:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 12:12 Wojciech Andralojc
[not found] ` <3FD2C4106EAA5C43838688C653B6E2AFDB8422@IRSMSX103.ger.corp.intel.com>
2016-01-06 17:33 ` Jerin Jacob [this message]
2016-01-20 10:56 ` [dpdk-dev] [PATCH v2] Patch introducing API to read/write Intel Architecture Model Specific Registers (MSR) Wojciech Andralojc
2016-01-20 11:25 ` Ananyev, Konstantin
2016-01-21 8:18 ` [dpdk-dev] [PATCH v3] " Wojciech Andralojc
2016-01-21 9:34 ` Thomas Monjalon
2016-01-21 10:38 ` Panu Matilainen
2016-01-21 10:51 ` Ananyev, Konstantin
2016-01-22 10:05 ` Panu Matilainen
2016-01-22 11:05 ` Ananyev, Konstantin
2016-01-22 11:37 ` Andralojc, WojciechX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106173348.GA23478@localhost.localdomain \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=wojciechx.andralojc@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).