From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Xie, Huawei" <huawei.xie@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 4/4] virtio: check if any kernel driver is manipulating the virtio device
Date: Thu, 7 Jan 2016 13:17:59 +0000 [thread overview]
Message-ID: <20160107131759.GA3222@sivlogin002.ir.intel.com> (raw)
In-Reply-To: <C37D651A908B024F974696C65296B57B4C5739A7@SHSMSX101.ccr.corp.intel.com>
On Mon, Jan 04, 2016 at 05:56:49PM +0000, Xie, Huawei wrote:
> On 1/5/2016 1:24 AM, Stephen Hemminger wrote:
> > On Mon, 4 Jan 2016 01:56:13 +0800
> > Huawei Xie <huawei.xie@intel.com> wrote:
> >
> >> + if (pci_dev->kdrv != RTE_KDRV_NONE) {
> >> + PMD_INIT_LOG(INFO,
> >> + "kernel driver is manipulating this device." \
> >> + " Please unbind the kernel driver.");
> > Splitting strings in general is a bad idea since it makes it harder to find log messages.
> > Also the first clause is lower case and the second is captialized.
> Got it. This is to avoid 80 char warning. Will put it in one line to
> make it friendly for searching.
> The first clause is lower is because it actually follows "%s():".
Indeed checkpatch lets logging functions be longer than 80 chars, so does not forces to split message.
But checkpatch detects kernel logging functions only, not ours, that is why we are still getting over 80 chars warning.
Should we ignore LONG_LINE_STRING warnings in checkpatch?
Thanks,
ferruh
next prev parent reply other threads:[~2016-01-07 13:18 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 3:50 [dpdk-dev] [Question] How pmd virtio works without UIO? Peter Xu
2015-12-22 7:00 ` Yuanhan Liu
2015-12-22 8:23 ` Peter Xu
2015-12-22 8:32 ` Yuanhan Liu
2015-12-22 9:56 ` Peter Xu
2015-12-22 10:47 ` Xie, Huawei
2015-12-22 10:53 ` Xie, Huawei
2015-12-22 11:39 ` Peter Xu
2015-12-22 14:31 ` Xie, Huawei
2015-12-22 16:38 ` Xie, Huawei
2015-12-23 1:55 ` Peter Xu
2015-12-23 2:09 ` Yuanhan Liu
2015-12-23 2:38 ` Peter Xu
2015-12-23 22:26 ` Thomas Monjalon
2015-12-24 3:30 ` Yuanhan Liu
2015-12-24 17:56 ` Stephen Hemminger
2015-12-23 2:01 ` Yuanhan Liu
2015-12-23 2:41 ` Peter Xu
2015-12-23 2:58 ` Yuanhan Liu
2015-12-23 5:13 ` Xie, Huawei
2015-12-23 22:20 ` Thomas Monjalon
2015-12-24 18:38 ` [dpdk-dev] [PATCH 0/4] check if any kernel driver is manipulating the virtio device Huawei Xie
2015-12-24 18:38 ` [dpdk-dev] [PATCH 1/4] eal: make the comment more accurate Huawei Xie
2015-12-24 18:38 ` [dpdk-dev] [PATCH 2/4] eal: set kdrv to RTE_KDRV_NONE if kernel driver isn't manipulating the device Huawei Xie
2015-12-28 20:24 ` David Marchand
2015-12-24 18:38 ` [dpdk-dev] [PATCH 3/4] virtio: return 1 to tell the upper layer we don't take over this device Huawei Xie
2015-12-28 5:25 ` Yuanhan Liu
2015-12-28 5:38 ` Xie, Huawei
2015-12-24 18:38 ` [dpdk-dev] [PATCH 4/4] virtio: check if any kernel driver is manipulating the device Huawei Xie
2015-12-28 5:26 ` Yuanhan Liu
2015-12-28 5:29 ` Xie, Huawei
2016-01-04 9:02 ` Xie, Huawei
2016-01-04 17:29 ` Stephen Hemminger
2016-01-05 14:44 ` Panu Matilainen
2015-12-28 3:08 ` [dpdk-dev] [PATCH 0/4] check if any kernel driver is manipulating the virtio device Peter Xu
2016-01-03 17:56 ` [dpdk-dev] [PATCH v2 0/4] fix the issue that DPDK takes over virtio device blindly Huawei Xie
2016-01-03 17:56 ` [dpdk-dev] [PATCH v2 1/4] eal: make the comment more accurate Huawei Xie
2016-01-03 17:56 ` [dpdk-dev] [PATCH v2 2/4] eal: set kdrv to RTE_KDRV_NONE if kernel driver isn't manipulating the device Huawei Xie
2016-01-03 17:56 ` [dpdk-dev] [PATCH v2 3/4] virtio: return 1 to tell the upper layer we don't take over this device Huawei Xie
2016-01-03 17:56 ` [dpdk-dev] [PATCH v2 4/4] virtio: check if any kernel driver is manipulating the virtio device Huawei Xie
2016-01-04 17:24 ` Stephen Hemminger
2016-01-04 17:56 ` Xie, Huawei
2016-01-05 1:56 ` Yuanhan Liu
2016-01-07 13:17 ` Ferruh Yigit [this message]
2016-01-07 14:17 ` Panu Matilainen
2016-01-27 12:43 ` Thomas Monjalon
2016-01-04 17:25 ` [dpdk-dev] [PATCH v2 0/4] fix the issue that DPDK takes over virtio device blindly Stephen Hemminger
2016-01-12 3:02 ` Xie, Huawei
2016-01-12 4:23 ` Santosh Shukla
2016-01-12 5:16 ` Xie, Huawei
2016-01-13 12:17 ` Santosh Shukla
2016-01-27 15:21 ` [dpdk-dev] [PATCH v3 " Huawei Xie
2016-01-27 15:21 ` [dpdk-dev] [PATCH v3 1/4] eal: make the comment more accurate Huawei Xie
2016-01-27 15:21 ` [dpdk-dev] [PATCH v3 2/4] eal: set kdrv to RTE_KDRV_NONE if kernel driver isn't manipulating the device Huawei Xie
2016-01-27 15:21 ` [dpdk-dev] [PATCH v3 3/4] virtio: return 1 to tell the upper layer we don't take over this device Huawei Xie
2016-01-27 15:21 ` [dpdk-dev] [PATCH v3 4/4] virtio: check if kernel driver is manipulating the virtio device Huawei Xie
2016-01-28 9:55 ` Panu Matilainen
2016-01-29 7:40 ` [dpdk-dev] [PATCH v3 0/4] fix the issue that DPDK takes over virtio device blindly Yuanhan Liu
2016-02-24 12:43 ` Thomas Monjalon
2016-02-26 6:09 ` Xie, Huawei
2016-02-26 8:40 ` David Marchand
2016-02-26 9:00 ` Xie, Huawei
2016-02-26 1:53 ` [dpdk-dev] [PATCH v4 " Huawei Xie
2016-02-26 1:53 ` [dpdk-dev] [PATCH v4 1/4] eal: make the comment more accurate Huawei Xie
2016-02-29 8:48 ` David Marchand
2016-02-26 1:53 ` [dpdk-dev] [PATCH v4 2/4] eal: set kdrv to RTE_KDRV_NONE if kernel driver isn't managing the device Huawei Xie
2016-02-29 2:34 ` Xie, Huawei
2016-02-29 8:46 ` David Marchand
2016-02-29 9:00 ` Xie, Huawei
2016-02-29 9:05 ` David Marchand
2016-02-26 1:53 ` [dpdk-dev] [PATCH v4 3/4] eal: call pci_ioport_map when " Huawei Xie
2016-02-29 9:02 ` David Marchand
2016-02-26 1:53 ` [dpdk-dev] [PATCH v4 4/4] virtio: return 1 to tell the upper layer we don't take over this device Huawei Xie
2016-02-29 13:15 ` Santosh Shukla
2016-03-01 7:16 ` Thomas Monjalon
2016-03-01 7:53 ` Xie, Huawei
2016-03-01 8:20 ` Thomas Monjalon
2016-03-01 8:39 ` Xie, Huawei
2016-03-01 9:55 ` Thomas Monjalon
2016-03-01 10:08 ` Xie, Huawei
2016-03-08 17:00 ` Xie, Huawei
2016-03-08 23:01 ` Thomas Monjalon
2016-03-08 15:33 ` [dpdk-dev] [PATCH v5 0/6] fix the issue that DPDK takes over virtio device blindly Huawei Xie
2016-03-08 15:33 ` [dpdk-dev] [PATCH v5 1/6] eal: make the comment more accurate Huawei Xie
2016-03-08 15:33 ` [dpdk-dev] [PATCH v5 2/6] eal: RTE_KDRV_NONE means kernel driver isn't managing the device Huawei Xie
2016-03-08 15:33 ` [dpdk-dev] [PATCH v5 3/6] eal: use new RTE_ARCH_X86 for x86 arch Huawei Xie
2016-03-09 23:04 ` Thomas Monjalon
2016-03-08 15:33 ` [dpdk-dev] [PATCH v5 4/6] eal: simple code rework Huawei Xie
2016-03-08 15:33 ` [dpdk-dev] [PATCH v5 5/6] eal: map IO port when kernel driver isn't managing the device Huawei Xie
2016-03-08 15:33 ` [dpdk-dev] [PATCH v5 6/6] virtio: return 1 to tell the upper layer we don't take over this device Huawei Xie
2016-03-09 23:23 ` Thomas Monjalon
2016-03-09 23:35 ` [dpdk-dev] [PATCH v5 0/6] fix the issue that DPDK takes over virtio device blindly Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107131759.GA3222@sivlogin002.ir.intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).