From: Bruce Richardson <bruce.richardson@intel.com>
To: Eric Kinzie <ehkinzie@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Doherty, Declan <declan.doherty@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 6/8] bond: handle slaves with fewer queues than bonding device
Date: Wed, 3 Feb 2016 04:28:55 -0700 [thread overview]
Message-ID: <20160203112854.GA13036@bricha3-MOBL3> (raw)
In-Reply-To: <20151204191831.GA20647@roosta.home>
On Fri, Dec 04, 2015 at 02:18:34PM -0500, Eric Kinzie wrote:
> On Fri Dec 04 19:36:09 +0100 2015, Andriy Berestovskyy wrote:
> > Hi guys,
> > I'm not quite sure if we can support less TX queues on a slave that easy:
> >
> > > queue_id = bond_slave_txqid(internals, i, bd_tx_q->queue_id);
> > > num_tx_slave = rte_eth_tx_burst(slaves[i], queue_id,
> > > slave_bufs[i], slave_nb_pkts[i]);
> >
> > It seems that two different lcores might end up writing to the same
> > slave queue at the same time, isn't it?
> >
> > Regards,
> > Andriy
>
> Andriy, I think you're probably right about this. Perhaps it should
> instead refuse to add or refuse to activate a slave with too few
> tx queues. Could probably fix this with another layer of buffering
> so that an lcore with a valid tx queue could pick up the mbufs later,
> but this doesn't seem very appealing.
>
> Eric
>
Hi Eric, Stephen, Declan,
all patches of the set apart from this one and the next (nos 6 & 7) have no
comments and have been acked. Is there a resolution on these two patches, so they
can be acked and merged?
Regards,
/Bruce
next prev parent reply other threads:[~2016-02-03 11:28 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 17:14 [dpdk-dev] [PATCH 0/8] bonding: fixes and enhancements Stephen Hemminger
2015-12-04 17:14 ` [dpdk-dev] [PATCH 1/8] bond: use existing enslaved device queues Stephen Hemminger
2016-01-05 13:32 ` Declan Doherty
2015-12-04 17:14 ` [dpdk-dev] [PATCH 2/8] bond mode 4: copy entire config structure Stephen Hemminger
2016-01-05 13:32 ` Declan Doherty
2015-12-04 17:14 ` [dpdk-dev] [PATCH 3/8] bond mode 4: do not ignore multicast Stephen Hemminger
2016-01-05 13:32 ` Declan Doherty
2015-12-04 17:14 ` [dpdk-dev] [PATCH 4/8] bond mode 4: allow external state machine Stephen Hemminger
2016-01-05 13:33 ` Declan Doherty
2015-12-04 17:14 ` [dpdk-dev] [PATCH 5/8] bond: active slaves with no primary Stephen Hemminger
2016-01-05 13:34 ` Declan Doherty
2015-12-04 17:14 ` [dpdk-dev] [PATCH 6/8] bond: handle slaves with fewer queues than bonding device Stephen Hemminger
2015-12-04 18:36 ` Andriy Berestovskyy
2015-12-04 19:18 ` Eric Kinzie
2016-01-05 13:46 ` Declan Doherty
2016-01-05 15:31 ` Stephen Hemminger
2016-02-03 11:28 ` Bruce Richardson [this message]
2016-02-03 15:17 ` Declan Doherty
2016-02-03 15:21 ` Thomas Monjalon
2016-02-18 10:26 ` Iremonger, Bernard
2016-02-19 19:17 ` [dpdk-dev] [PATCH v2 0/6] bonding: fixes and enhancements Eric Kinzie
2016-02-19 19:17 ` [dpdk-dev] [PATCH v2 1/6] bond: use existing enslaved device queues Eric Kinzie
2016-02-19 19:17 ` [dpdk-dev] [PATCH v2 2/6] bond mode 4: copy entire config structure Eric Kinzie
2016-02-19 19:17 ` [dpdk-dev] [PATCH v2 3/6] bond mode 4: do not ignore multicast Eric Kinzie
2016-02-19 19:17 ` [dpdk-dev] [PATCH v2 4/6] bond mode 4: allow external state machine Eric Kinzie
2016-02-22 13:03 ` Panu Matilainen
2016-02-25 15:22 ` Iremonger, Bernard
2016-03-01 17:31 ` [dpdk-dev] [PATCH V3 0/4] bonding: fixes and enhancements Eric Kinzie
2016-03-01 17:31 ` [dpdk-dev] [PATCH V3 1/4] bond mode 4: copy entire config structure Eric Kinzie
2016-03-01 17:32 ` [dpdk-dev] [PATCH V3 2/4] bond mode 4: do not ignore multicast Eric Kinzie
2016-03-01 17:32 ` [dpdk-dev] [PATCH V3 3/4] bond: active slaves with no primary Eric Kinzie
2016-03-01 17:32 ` [dpdk-dev] [PATCH V3 4/4] bond: do not activate slave twice Eric Kinzie
2016-03-10 15:41 ` [dpdk-dev] [PATCH V3 0/4] bonding: fixes and enhancements Bruce Richardson
2016-03-01 17:40 ` [dpdk-dev] [PATCH v2 4/6] bond mode 4: allow external state machine Eric Kinzie
2016-03-02 9:49 ` Iremonger, Bernard
2016-02-19 19:17 ` [dpdk-dev] [PATCH v2 5/6] bond: active slaves with no primary Eric Kinzie
2016-02-19 19:17 ` [dpdk-dev] [PATCH v2 6/6] bond: do not activate slave twice Eric Kinzie
2015-12-04 17:14 ` [dpdk-dev] [PATCH 7/8] bond: per-slave intermediate rx ring Stephen Hemminger
2015-12-04 17:14 ` [dpdk-dev] [PATCH 8/8] bond: do not activate slave twice Stephen Hemminger
2016-01-05 13:47 ` Declan Doherty
2015-12-23 10:51 ` [dpdk-dev] [PATCH 0/8] bonding: fixes and enhancements Iremonger, Bernard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160203112854.GA13036@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ehkinzie@gmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).