From: Bruce Richardson <bruce.richardson@intel.com>
To: Wang Xiao W <xiao.w.wang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] testpmd: fix wrong prompt in tx_vlan set command handler
Date: Thu, 4 Feb 2016 09:52:54 +0000 [thread overview]
Message-ID: <20160204095254.GA8868@bricha3-MOBL3> (raw)
In-Reply-To: <1454574452-30741-2-git-send-email-xiao.w.wang@intel.com>
On Thu, Feb 04, 2016 at 04:27:32PM +0800, Wang Xiao W wrote:
> When using testpmd, sometimes we forget the right order of port_id and
> vid in "tx_vlan set (port_id) vlan_id[, vlan_id_outer]\n" command, and
> input "tx_vlan set 51 0", we'll get a strange prompt saying "Error, as
> QinQ has been enabled.".
>
> In cmd_tx_vlan_set_parsed function, the first thing we do is checking
> the port's vlan_offload capability, rather than checking validity of the
> port_id, therefore if it's an invalid port_id we'll get the above wrong
> message. We should always make sure that we get a valid port_id before
> we do other things.
>
> It's the similar issue for cmd_tx_vlan_set_qinq_parsed function.
>
> Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>
Please include a fixes line, in patches fixing problems.
thanks,
/Bruce
prev parent reply other threads:[~2016-02-04 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 11:13 [dpdk-dev] [PATCH 1/2] testpmd: optimize tx_vlan_set and tx_qinq_set function Wang Xiao W
2015-12-22 11:36 ` [dpdk-dev] [PATCH v2] testpmd: fix a bug in tx_vlan set command support Wang Xiao W
2015-12-22 11:36 ` Wang Xiao W
2016-02-04 8:27 ` [dpdk-dev] [PATCH v3] testpmd: fix wrong prompt in tx_vlan set command handler Wang Xiao W
2016-02-04 8:27 ` Wang Xiao W
2016-02-04 9:52 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204095254.GA8868@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).