From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Reshma Pattan <reshma.pattan@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] kdp: add virtual PMD for kernel slow data path communication
Date: Tue, 9 Feb 2016 17:51:47 +0000 [thread overview]
Message-ID: <20160209175147.GA19213@sivlogin002.ir.intel.com> (raw)
In-Reply-To: <56BA2303.3000809@intel.com>
On Tue, Feb 09, 2016 at 05:33:55PM +0000, Reshma Pattan wrote:
> Hi Ferruh,
>
Hi Reshma,
> On 1/27/2016 4:32 PM, Ferruh Yigit wrote:
>> This patch provides slow data path communication to the Linux kernel.
>> Patch is based on librte_kni, and heavily re-uses it.
>>
>> The main difference is librte_kni library converted into a PMD, to
>> provide ease of use for applications.
>>
>> Now any application can use slow path communication without any update
>> in application, because of existing eal support for virtual PMD.
>>
>> Also this PMD supports two methods to send packets to the Linux, first
>> one is custom FIFO implementation with help of KDP kernel module, second
>> one is Linux in-kernel tun/tap support. PMD first checks for KDP kernel
>> module, if fails it tries to create and use a tap interface.
>>
>> With FIFO method: PMD's rx_pkt_burst() get packets from FIFO,
>> and tx_pkt_burst() puts packet to the FIFO.
>> The corresponding Linux virtual network device driver code
>> also gets/puts packets from FIFO as they are coming from hardware.
>>
>> With tun/tap method: no external kernel module required, PMD reads from
>> and writes packets to the tap interface file descriptor. Tap interface
>> has performance penalty against FIFO implementation.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> diff --git a/doc/guides/nics/pcap_ring.rst
>> b/doc/guides/nics/pcap_ring.rst
>> index 46aa3ac..78b7b61 100644
>> --- a/doc/guides/nics/pcap_ring.rst
>> +++ b/doc/guides/nics/pcap_ring.rst
>> @@ -28,11 +28,11 @@
>> +
>> +
>> +DPDK application can be used to forward packages between these interfaces:
>> +
>
> Packages ==> packets.?
>
Right, I will fix, thanks.
>> diff --git a/drivers/net/kdp/rte_eth_kdp.c b/drivers/net/kdp/rte_eth_kdp.c
>> new file mode 100644
>> index 0000000..ac650d7
>> --- /dev/null
>> +++ b/drivers/net/kdp/rte_eth_kdp.c
>> @@ -0,0 +1,481 @@
>>
>
> No public API to create KDP PMD device. We should have one right?
>
Doesn't have to have one, KDP does not have a requirement to have right now.
It is possible to create PMD with eal --vdev parameter...
>> diff --git a/drivers/net/kdp/rte_kdp.h b/drivers/net/kdp/rte_kdp.h
>> new file mode 100644
>> index 0000000..b9db048
>> --- /dev/null
>> +++ b/drivers/net/kdp/rte_kdp.h
>> @@ -0,0 +1,126 @@
>>
>> +struct rte_kdp_tap *rte_kdp_tap_init(uint16_t port_id);
>> +struct rte_kdp *rte_kdp_init(uint16_t port_id);
>> +
>> +int rte_kdp_start(struct rte_kdp *kdp, struct rte_mempool *pktmbuf_pool,
>> + const struct rte_kdp_conf *conf);
>> +
>> +unsigned rte_kdp_rx_burst(struct rte_kdp *kdp,
>> + struct rte_mbuf **mbufs, unsigned num);
>> +
>> +unsigned rte_kdp_tx_burst(struct rte_kdp *kdp,
>> + struct rte_mbuf **mbufs, unsigned num);
>> +
>> +int rte_kdp_release(struct rte_kdp *kdp);
>> +
>> +void rte_kdp_close(void);
>>
>
> These functions can be static.
>
No, this header used by multiple sources, the function declarations here are the ones in the scope of other file.
Thanks,
ferruh
next prev parent reply other threads:[~2016-02-09 17:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 16:32 [dpdk-dev] [PATCH 0/2] slow data path communication between DPDK port and Linux Ferruh Yigit
2016-01-27 16:32 ` [dpdk-dev] [PATCH 1/2] kdp: add kernel data path kernel module Ferruh Yigit
2016-02-08 17:14 ` Reshma Pattan
2016-02-09 10:53 ` Ferruh Yigit
2016-01-27 16:32 ` [dpdk-dev] [PATCH 2/2] kdp: add virtual PMD for kernel slow data path communication Ferruh Yigit
2016-01-28 8:16 ` Xu, Qian Q
2016-01-29 16:04 ` Yigit, Ferruh
2016-02-09 17:33 ` Reshma Pattan
2016-02-09 17:51 ` Ferruh Yigit [this message]
2016-02-19 5:05 ` [dpdk-dev] [PATCH v2 0/2] slow data path communication between DPDK port and Linux Ferruh Yigit
2016-02-19 5:05 ` [dpdk-dev] [PATCH v2 1/2] kdp: add kernel data path kernel module Ferruh Yigit
2016-02-19 5:05 ` [dpdk-dev] [PATCH v2 2/2] kdp: add virtual PMD for kernel slow data path communication Ferruh Yigit
2016-03-09 11:17 ` [dpdk-dev] [PATCH v3 0/2] slow data path communication between DPDK port and Linux Ferruh Yigit
2016-03-09 11:17 ` [dpdk-dev] [PATCH v3 1/2] kdp: add kernel data path kernel module Ferruh Yigit
2016-03-09 11:17 ` [dpdk-dev] [PATCH v3 2/2] kdp: add virtual PMD for kernel slow data path communication Ferruh Yigit
2016-03-14 15:32 ` [dpdk-dev] [PATCH v3 0/2] slow data path communication between DPDK port and Linux Ferruh Yigit
2016-03-16 7:26 ` Panu Matilainen
2016-03-16 8:19 ` Ferruh Yigit
2016-03-16 8:22 ` Panu Matilainen
2016-03-16 10:26 ` Ferruh Yigit
2016-03-16 10:45 ` Thomas Monjalon
2016-03-16 11:07 ` Mcnamara, John
2016-03-16 11:13 ` Ferruh Yigit
2016-03-16 13:23 ` Panu Matilainen
2016-03-16 13:15 ` Panu Matilainen
2016-03-16 13:58 ` Thomas Monjalon
2016-03-16 15:03 ` Panu Matilainen
2016-03-16 15:15 ` Thomas Monjalon
2016-03-16 11:07 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160209175147.GA19213@sivlogin002.ir.intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).