From: Bruce Richardson <bruce.richardson@intel.com>
To: Jingjing Wu <jingjing.wu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/3] i40e: enable DCB in VMDQ vsis
Date: Fri, 12 Feb 2016 12:16:35 +0000 [thread overview]
Message-ID: <20160212121635.GC18808@bricha3-MOBL3> (raw)
In-Reply-To: <1453280236-8778-2-git-send-email-jingjing.wu@intel.com>
On Wed, Jan 20, 2016 at 04:57:14PM +0800, Jingjing Wu wrote:
> Previously, DCB is only enabled on PF, queue mapping and BW
> configuration is only done on PF vsi. This patch enabled DCB
> for VMDQ vsis by following steps:
> 1. Take BW and ETS configuration on VEB.
> 2. Take BW and ETS configuration on VMDQ vsis.
> 3. Update TC and queues mapping on VMDQ vsis.
> To enable DCB on VMDQ, the number of TCs should not be lager than
typo: s/lager/larger/
> the number of queues in VMDQ pools, and the number of queues per
> VMDQ pool is specified by CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM
> in config/common_* file.
>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
In the title and commit log, can you please capitalize the abbreviation VSI, so
that VSIs is recognisable as a plural of the acronym, and not as the word "vsis",
which confused me for a while. :-)
Can you also explain what ETS stands for. [Not sure if VSI also needs to be
expanded out the first time it is used in the message]
> ---
> doc/guides/rel_notes/release_2_3.rst | 2 +
> drivers/net/i40e/i40e_ethdev.c | 153 ++++++++++++++++++++++++++++++-----
> drivers/net/i40e/i40e_ethdev.h | 28 ++++---
> 3 files changed, 151 insertions(+), 32 deletions(-)
>
> diff --git a/doc/guides/rel_notes/release_2_3.rst b/doc/guides/rel_notes/release_2_3.rst
> index 99de186..cd3d391 100644
> --- a/doc/guides/rel_notes/release_2_3.rst
> +++ b/doc/guides/rel_notes/release_2_3.rst
> @@ -4,6 +4,8 @@ DPDK Release 2.3
> New Features
> ------------
>
> +* **Added i40e DCB support in VMDQ mode.**
Suggest to reword this as: "Added support for DCB in VMDQ mode to i40e driver"
> +
>
> Resolved Issues
> ---------------
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index bf6220d..fbafcc6 100644
<snip>
Thanks,
/Bruce
next prev parent reply other threads:[~2016-02-12 12:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 2:50 [dpdk-dev] [RFC PATCH 0/3] extend vmdq_dcb sample for X710 supporting Jingjing Wu
2016-01-11 2:50 ` [dpdk-dev] [RFC PATCH 1/3] i40e: enable DCB in VMDQ vsis Jingjing Wu
2016-01-11 2:50 ` [dpdk-dev] [RFC PATCH 2/3] ixgbe: add more multi queue mode checking Jingjing Wu
2016-01-11 2:50 ` [dpdk-dev] [RFC PATCH 3/3] examples/vmdq_dcb: extend sample for X710 supporting Jingjing Wu
2016-01-20 8:57 ` [dpdk-dev] [PATCH 0/3] extend vmdq_dcb " Jingjing Wu
2016-01-20 8:57 ` [dpdk-dev] [PATCH 1/3] i40e: enable DCB in VMDQ vsis Jingjing Wu
2016-02-12 12:16 ` Bruce Richardson [this message]
2016-01-20 8:57 ` [dpdk-dev] [PATCH 2/3] ixgbe: add more multi queue mode checking Jingjing Wu
2016-01-20 8:57 ` [dpdk-dev] [PATCH 3/3] examples/vmdq_dcb: extend sample for X710 supporting Jingjing Wu
2016-02-17 6:58 ` [dpdk-dev] [PATCH v2 0/3] extend vmdq_dcb " Jingjing Wu
2016-02-17 6:58 ` [dpdk-dev] [PATCH v2 1/3] i40e: enable DCB in VMDQ VSIs Jingjing Wu
2016-02-24 6:58 ` Zhang, Helin
2016-02-25 7:04 ` Wu, Jingjing
2016-02-17 6:58 ` [dpdk-dev] [PATCH v2 2/3] ixgbe: disallow unsupported RX mode Jingjing Wu
2016-02-17 6:58 ` [dpdk-dev] [PATCH v2 3/3] examples/vmdq_dcb: extend sample for X710 supporting Jingjing Wu
2016-02-25 7:33 ` [dpdk-dev] [PATCH v3 0/3] extend vmdq_dcb " Jingjing Wu
2016-02-25 7:33 ` [dpdk-dev] [PATCH v3 1/3] i40e: enable DCB in VMDQ VSIs Jingjing Wu
2016-02-26 8:06 ` Zhang, Helin
2016-02-25 7:33 ` [dpdk-dev] [PATCH v3 2/3] ixgbe: disallow unsupported RX mode Jingjing Wu
2016-02-26 8:06 ` Zhang, Helin
2016-02-25 7:33 ` [dpdk-dev] [PATCH v3 3/3] examples/vmdq_dcb: extend sample for X710 supporting Jingjing Wu
2016-02-26 8:06 ` Zhang, Helin
2016-03-08 17:25 ` [dpdk-dev] [PATCH v3 0/3] extend vmdq_dcb " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212121635.GC18808@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).