From: Bruce Richardson <bruce.richardson@intel.com>
To: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] fm10k: optimize legacy TX func
Date: Tue, 16 Feb 2016 15:27:35 +0000 [thread overview]
Message-ID: <20160216152735.GA13784@bricha3-MOBL3> (raw)
In-Reply-To: <1453974359-20895-1-git-send-email-jing.d.chen@intel.com>
On Thu, Jan 28, 2016 at 05:45:59PM +0800, Chen Jing D(Mark) wrote:
> From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
>
> When legacy TX func tries to free a bunch of mbufs, it will free
> them one by one. This change will scan the free list and merge the
> requests in case they belongs to same pool, then free once, which
> will reduce cycles on freeing mbufs.
>
> Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
> ---
> doc/guides/rel_notes/release_2_3.rst | 2 +
> drivers/net/fm10k/fm10k_rxtx.c | 59 ++++++++++++++++++++++++++++-----
> 2 files changed, 52 insertions(+), 9 deletions(-)
>
> diff --git a/doc/guides/rel_notes/release_2_3.rst b/doc/guides/rel_notes/release_2_3.rst
> index 99de186..20ce78d 100644
> --- a/doc/guides/rel_notes/release_2_3.rst
> +++ b/doc/guides/rel_notes/release_2_3.rst
> @@ -3,7 +3,9 @@ DPDK Release 2.3
>
> New Features
> ------------
> +* **Optimize fm10k Tx func.**
>
> + * Free multiple mbufs at a time to reduce freeing mbuf cycles.
>
Is this really a significant enough change to warrant being called out in the
release notes?
Personally, I don't think so, so if you are ok with it, I'll just apply this
patch without the RN update.
/Bruce
next prev parent reply other threads:[~2016-02-16 15:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 9:45 Chen Jing D(Mark)
2016-02-16 15:27 ` Bruce Richardson [this message]
2016-02-16 15:34 ` Chen, Jing D
2016-02-18 9:20 ` He, Shaopeng
2016-02-24 12:01 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216152735.GA13784@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jing.d.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).