From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org,
"Nicolás Pernas Maradei" <nicolas.pernas.maradei@emutex.com>
Subject: Re: [dpdk-dev] [PATCH 2/3] ring: remove duplicate fields in internal data struct
Date: Thu, 18 Feb 2016 09:50:36 +0000 [thread overview]
Message-ID: <20160218095036.GA1524@sivlogin002.ir.intel.com> (raw)
In-Reply-To: <20160217173655.GD11736@bricha3-MOBL3>
On Wed, Feb 17, 2016 at 05:36:55PM +0000, Bruce Richardson wrote:
> On Fri, Jan 29, 2016 at 05:16:21PM +0000, Ferruh Yigit wrote:
> > 1- Remove duplicate nb_rx/tx_queues fields from internals
> > 2- Remove data->rx/tx_queues allocation, whose auto allocated by
> > libether
> > 3- Remove duplicate data->rx/tx_queues[i] assignments
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> > drivers/net/ring/rte_eth_ring.c | 52 +++++++++++------------------------------
> > 1 file changed, 14 insertions(+), 38 deletions(-)
> >
>
> Hi Ferruh,
Hi Bruce,
>
> does this patch not break rte_eth_from_ring() and rte_eth_from_rings() since
> the "auto allocation" you refer to is only performed on eth_dev_configure, I
> believe. Currently, you can create an rte_ring and then use it as though it
> were an ethdev by calling:
> port_id = rte_eth_from_ring(r)
>
> With this change, I believe the user instead has to now call eth_from_ring,
> then do a series of configure and queue setup calls just to make the new
> ethdev usable.
>
I wasn't aware requirement to use without config and setup calls, yes this patch breaks it. I will update the patch to recover this kind of usage.
Thanks,
ferruh
next prev parent reply other threads:[~2016-02-18 9:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 17:16 [dpdk-dev] [PATCH 0/3] clean-up on virtual PMDs Ferruh Yigit
2016-01-29 17:16 ` [dpdk-dev] [PATCH 1/3] pcap: remove duplicate fields in internal data struct Ferruh Yigit
2016-01-29 17:16 ` [dpdk-dev] [PATCH 2/3] ring: " Ferruh Yigit
2016-02-17 17:36 ` Bruce Richardson
2016-02-18 9:50 ` Ferruh Yigit [this message]
2016-01-29 17:16 ` [dpdk-dev] [PATCH 3/3] null: " Ferruh Yigit
2016-02-03 6:21 ` Tetsuya Mukawa
2016-02-18 11:26 ` [dpdk-dev] [PATCH v2 0/3] clean-up on virtual PMDs Ferruh Yigit
2016-02-18 11:26 ` [dpdk-dev] [PATCH v2 1/3] pcap: remove duplicate fields in internal data struct Ferruh Yigit
2016-02-22 9:54 ` Nicolas Pernas Maradei
2016-02-18 11:26 ` [dpdk-dev] [PATCH v2 2/3] ring: " Ferruh Yigit
2016-02-22 9:55 ` Nicolas Pernas Maradei
2016-02-23 15:26 ` Bruce Richardson
2016-02-23 15:58 ` Ferruh Yigit
2016-02-23 16:06 ` Bruce Richardson
2016-02-18 11:26 ` [dpdk-dev] [PATCH v2 3/3] null: " Ferruh Yigit
2016-02-22 9:56 ` Nicolas Pernas Maradei
2016-02-26 15:26 ` [dpdk-dev] [PATCH v3 0/3] clean-up on virtual PMDs Ferruh Yigit
2016-02-26 15:26 ` [dpdk-dev] [PATCH v3 1/3] pcap: remove duplicate fields in internal data struct Ferruh Yigit
2016-02-26 15:26 ` [dpdk-dev] [PATCH v3 2/3] ring: rename " Ferruh Yigit
2016-02-26 16:35 ` Bruce Richardson
2016-02-26 15:26 ` [dpdk-dev] [PATCH v3 3/3] null: remove duplicate " Ferruh Yigit
2016-02-26 16:58 ` [dpdk-dev] [PATCH v4 0/3] clean-up on virtual PMDs Ferruh Yigit
2016-02-26 16:58 ` [dpdk-dev] [PATCH v4 1/3] pcap: remove duplicate fields in internal data struct Ferruh Yigit
2016-02-26 16:58 ` [dpdk-dev] [PATCH v4 2/3] ring: variable rename and code cleanup Ferruh Yigit
2016-03-10 11:11 ` Bruce Richardson
2016-02-26 16:58 ` [dpdk-dev] [PATCH v4 3/3] null: remove duplicate fields in internal data struct Ferruh Yigit
2016-03-10 11:12 ` [dpdk-dev] [PATCH v4 0/3] clean-up on virtual PMDs Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218095036.GA1524@sivlogin002.ir.intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nicolas.pernas.maradei@emutex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).