From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net
Date: Thu, 18 Feb 2016 21:56:03 +0800 [thread overview]
Message-ID: <20160218135603.GO21426@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <56C5C98E.7010205@redhat.com>
On Thu, Feb 18, 2016 at 03:39:26PM +0200, Panu Matilainen wrote:
> On 02/18/2016 03:25 PM, Yuanhan Liu wrote:
> >On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote:
> >>Commit d0cf91303d73 added dependency on librte_net headers to vhost
> >>but did not add this to the Makefile, which makes builds
> >>non-deterministic. Curiously it is non-parallel build that is
> >>consistently broken by this missing dependency, usually it's the other
> >>way around, but trying to build without -j(n) fails with:
> >
> >Yeah, I have confirmed it; I was wondering why I didn't meet such build
> >error.
> >
> >>
> >> dpdk/lib/librte_vhost/vhost_rxtx.c:41:20:
> >> fatal error: rte_ip.h: No such file or directory
> >>
> >>Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities")
> >>Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
> >
> >Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> >
> >Thanks.
> >
> >BTW, please cc me for virtio/vhost patches next time, otherwise, it's
> >easily got overlooked: too many emails.
>
> Hmm, I thought I did. Looking more carefully now, I mixed up the patch
> author (who was CC'd) with you:
I didn't see the author was cc'ed from my email client:
Date: Thu, 18 Feb 2016 11:47:43 +0200
From: Panu Matilainen <pmatilai@redhat.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net
>
> commit d0cf91303d731997945420832ee245b21f292e19
> Author: Jijiang Liu <jijiang.liu@intel.com>
>
> I hate it when people call me Paul (commonly happens) just because it
Hmm... I didn't call you that, right?
> vaguely resembles my name,
Indeed :)
> so I really should do better than this.
> Apologies, I'll pay closer attention in the future.
Never mind, it's not a big deal. Emails with me CC'ed are highlighted
in my mutt email client, therefore, it's unlikely I will miss them.
--yliu
next prev parent reply other threads:[~2016-02-18 13:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 9:47 Panu Matilainen
2016-02-18 13:25 ` Yuanhan Liu
2016-02-18 13:39 ` Panu Matilainen
2016-02-18 13:56 ` Yuanhan Liu [this message]
2016-02-18 14:07 ` Panu Matilainen
2016-02-19 1:56 ` Yuanhan Liu
2016-02-19 10:24 ` Thomas Monjalon
2016-02-23 15:34 ` Bruce Richardson
2016-02-18 19:26 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218135603.GO21426@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).