From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 4/5] mlx5: add support for flow director
Date: Tue, 23 Feb 2016 18:38:28 +0100 [thread overview]
Message-ID: <20160223173828.GY27079@6wind.com> (raw)
In-Reply-To: <2522248.H1QVqHKcgq@xps13>
On Tue, Feb 23, 2016 at 06:14:19PM +0100, Thomas Monjalon wrote:
> 2016-02-23 15:13, Bruce Richardson:
> > On Thu, Feb 18, 2016 at 05:10:16PM +0100, Adrien Mazarguil wrote:
> > > Hi Bruce,
> > >
> > > On Wed, Feb 17, 2016 at 05:13:44PM +0000, Bruce Richardson wrote:
> > > > Hi Adrien, Yaacov,
> > > >
> > > > this patch raises a lot of warnings (17) with checkpatch. Can you perhaps look
> > > > to see if this number can be reduced.
> > >
> > > We actually did it before submitting that patch, there is indeed a bunch of
> > > remaining warnings that have been left on purpose. Not sure if we have the
> > > same configuration for checkpatch, but they should fall into the following
> > > categories:
> > >
> > > - "WARNING: return of an errno should typically be negative" - All return
> > > values are documented in the code. Since this PMD uses syscalls in its
> > > control path, it uses positive errno values internally for
> > > consistency. Public callback functions however return negative error
> > > values.
> > >
> > > - "WARNING: line over 80 characters" - Well, although I'm a big fan of the
> > > 80 characters limit, breaking those would have made the code harder to
> > > read.
> > >
> > > - "WARNING: Missing a blank line after declarations" - It's actually a
> > > declaration through a macro, there is no missing blank line.
> > >
> > > - "WARNING: networking block comments don't use an empty /* line" - Not sure
> > > if we really care? I don't particularly mind.
> > >
> > > - "CHECK: Comparison to NULL could be written "!" - I do not mind either,
> > > writing the full check seems clearer to me.
> > >
> > > - "CHECK: Unnecessary parentheses around fdir_info->mask" - Looks like a
> > > valid, although minor error.
> > >
> > > Please tell me which of these still need to be fixed.
> > >
> > Hi Adrien,
> >
> > sorry for the delayed reply, I was out for a couple of days.
> >
> > As none of the above are errors, I'm not going to mandate that they be fixed
> > before I merge in the patch, so long as you as maintainer are happy with them.
> >
> > My request mainly came about because of the sheer number of warnings that were
> > being flagged. To keep the codebase clean requires constant discipline, so I
> > don't like seeing patches where 17 warnings are flagged. I was hoping since
> > a new rev of the set was likely anyway that some steps could be taken to reduce
> > that number.
> >
> > Thomas, any thoughts here, since I'm still "learning the ropes" as committer.
> > Do you have any rules-of-thumb or guidelines as regards checkpatch warnings? The
> > contributor guide only seems to cover running checkpatch, not anything about
> > what to do with the output.
>
> I totally agree with you, Bruce.
> Everybody must make some effort to keep consistency and avoid coding style
> exceptions. Some code areas are not yet fully compliant with the rules,
> depending of their history and... their maintainers ;)
> I think we can tolerate some exceptions like for the 80 char limit.
> Some checks may be disabled after discussion (networking block comments?).
Actually you can ignore this one and NULL comparison checks - they do not
show up when using scripts/checkpatches.sh (I was previously using
checkpatch.pl directly).
I've fixed and sent updated versions of these patchsets anyway, with errno
warnings still present since it's a design decision. We can discuss it if
necessary.
> Other checks deserve to be followed more strictly (e.g. negative errno).
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2016-02-23 17:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 10:31 [dpdk-dev] [PATCH 0/5] Add flow director and RX VLAN stripping support Adrien Mazarguil
2016-01-29 10:31 ` [dpdk-dev] [PATCH 1/5] mlx5: refactor special flows handling Adrien Mazarguil
2016-01-29 10:31 ` [dpdk-dev] [PATCH 2/5] mlx5: add special flows (broadcast and IPv6 multicast) Adrien Mazarguil
2016-01-29 10:32 ` [dpdk-dev] [PATCH 3/5] mlx5: make flow steering rule generator more generic Adrien Mazarguil
2016-01-29 10:32 ` [dpdk-dev] [PATCH 4/5] mlx5: add support for flow director Adrien Mazarguil
2016-02-17 17:13 ` Bruce Richardson
2016-02-18 16:10 ` Adrien Mazarguil
2016-02-23 15:13 ` Bruce Richardson
2016-02-23 17:14 ` Thomas Monjalon
2016-02-23 17:38 ` Adrien Mazarguil [this message]
2016-01-29 10:32 ` [dpdk-dev] [PATCH 5/5] mlx5: add support for RX VLAN stripping Adrien Mazarguil
2016-02-17 17:14 ` [dpdk-dev] [PATCH 0/5] Add flow director and RX VLAN stripping support Bruce Richardson
2016-02-18 16:27 ` Adrien Mazarguil
2016-02-22 18:02 ` [dpdk-dev] [PATCH v2 " Adrien Mazarguil
2016-02-22 18:02 ` [dpdk-dev] [PATCH v2 1/5] mlx5: refactor special flows handling Adrien Mazarguil
2016-02-22 18:02 ` [dpdk-dev] [PATCH v2 2/5] mlx5: add special flows (broadcast and IPv6 multicast) Adrien Mazarguil
2016-02-22 18:02 ` [dpdk-dev] [PATCH v2 3/5] mlx5: make flow steering rule generator more generic Adrien Mazarguil
2016-02-22 18:02 ` [dpdk-dev] [PATCH v2 4/5] mlx5: add support for flow director Adrien Mazarguil
2016-02-22 18:02 ` [dpdk-dev] [PATCH v2 5/5] mlx5: add support for RX VLAN stripping Adrien Mazarguil
2016-03-03 14:26 ` [dpdk-dev] [PATCH v3 0/5] Add flow director and RX VLAN stripping support Adrien Mazarguil
2016-03-03 14:26 ` [dpdk-dev] [PATCH v3 1/5] mlx5: refactor special flows handling Adrien Mazarguil
2016-03-03 14:26 ` [dpdk-dev] [PATCH v3 2/5] mlx5: add special flows (broadcast and IPv6 multicast) Adrien Mazarguil
2016-03-03 14:26 ` [dpdk-dev] [PATCH v3 3/5] mlx5: make flow steering rule generator more generic Adrien Mazarguil
2016-03-03 14:26 ` [dpdk-dev] [PATCH v3 4/5] mlx5: add support for flow director Adrien Mazarguil
2016-03-03 14:26 ` [dpdk-dev] [PATCH v3 5/5] mlx5: add support for RX VLAN stripping Adrien Mazarguil
2016-03-09 16:11 ` [dpdk-dev] [PATCH v3 0/5] Add flow director and RX VLAN stripping support Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223173828.GY27079@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).