From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Santosh Shukla <sshukla@mvista.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] virtio: Use cpuflag for vector api
Date: Tue, 1 Mar 2016 13:59:11 +0800 [thread overview]
Message-ID: <20160301055911.GM14300@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1456750690-3210-1-git-send-email-sshukla@mvista.com>
On Mon, Feb 29, 2016 at 06:28:10PM +0530, Santosh Shukla wrote:
> Check cpuflag macro before using vectored api.
> -virtio_recv_pkts_vec() uses _sse3__ simd instruction for now so added cpuflag.
> - Also wrap other vectored freind api ie..
> 1) virtqueue_enqueue_recv_refill_simple
> 2) virtio_rxq_vec_setup
>
> - removed VIRTIO_PMD=n from armv7/v8 config.
>
> todo:
> 1) Move virtio_recv_pkts_vec() implementation to
> drivers/virtio/virtio_vec_<arch>.h file.
> 2) Remove use_simple_rxtx flag, so that virtio/virtio_vec_<arch>.h
> files to provide vectored/non-vectored rx/tx apis.
>
> Signed-off-by: Santosh Shukla <sshukla@mvista.com>
> ---
> - v2: Removed VIRTIO_PMD=n from arm v7/v8
Firstly, I would not suggest you to send another new version, while there
still was discussions ongoing on old version.
And, you should not mix the ARM stuff here; this patch should only do
what the patch title tells. In generic, don't do two or more things in
one patch.
--yliu
next prev parent reply other threads:[~2016-03-01 5:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 8:51 [dpdk-dev] [PATCH v1] " Santosh Shukla
2016-02-29 4:27 ` Yuanhan Liu
2016-02-29 5:33 ` Xie, Huawei
2016-02-29 12:31 ` Santosh Shukla
2016-03-01 5:55 ` Yuanhan Liu
2016-03-01 6:10 ` Santosh Shukla
2016-03-01 6:22 ` Yuanhan Liu
2016-02-29 12:58 ` [dpdk-dev] [PATCH v2] " Santosh Shukla
2016-03-01 5:59 ` Yuanhan Liu [this message]
2016-03-01 6:08 ` Santosh Shukla
2016-03-01 6:32 ` Yuanhan Liu
2016-03-01 10:07 ` Santosh Shukla
2016-03-01 10:02 ` [dpdk-dev] [PATCH v1 0/3] virtio vector and misc Santosh Shukla
2016-03-01 10:02 ` [dpdk-dev] [PATCH v1 1/3] virtio: use vector rx/tx for ssse cpuflag only Santosh Shukla
2016-03-01 10:02 ` [dpdk-dev] [PATCH v1 2/3] config: enable virtio for armv7/v8 Santosh Shukla
2016-03-01 10:02 ` [dpdk-dev] [PATCH v1 3/3] guide/release: add virtio for arm feature info Santosh Shukla
2016-03-02 8:32 ` [dpdk-dev] [PATCH v1 0/3] virtio vector and misc Yuanhan Liu
2016-03-02 8:41 ` Santosh Shukla
2016-03-03 13:26 ` Thomas Monjalon
2016-03-03 13:50 ` Santosh Shukla
2016-03-01 9:11 ` [dpdk-dev] [PATCH v1] virtio: Use cpuflag for vector api Qiu, Michael
2016-03-01 9:45 ` Santosh Shukla
2016-03-02 2:10 ` Qiu, Michael
2016-03-02 2:49 ` Yuanhan Liu
2016-03-04 6:36 ` Qiu, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301055911.GM14300@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=sshukla@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).