From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] config: remove duplicate configuration information
Date: Mon, 7 Mar 2016 12:41:07 +0000 [thread overview]
Message-ID: <20160307124107.GA16816@bricha3-MOBL3> (raw)
In-Reply-To: <5474006.zCJzWiptFr@xps13>
On Sun, Mar 06, 2016 at 10:35:50AM +0100, Thomas Monjalon wrote:
> 2016-03-06 01:11, Ferruh Yigit:
> > On 3/4/2016 10:43 PM, Thomas Monjalon wrote:
> > > 2016-03-04 12:11, Keith Wiles:
> > >> In order to cleanup the configuration files some and reduce
> > >> the number of duplicate configuration information. Add a new
> > >> file called common_base which contains just about all of the
> > >> configuration lines in one place. Then have the common_bsdapp,
> > >> common_linuxapp files include this one file. Then in those OS
> > >> specific files add the delta configuration lines.
> > >>
> > >> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> > >
> > > It's also fixing the crypto settings which were mispelled for BSD.
> > >
> > > Applied with few cosmetic adjustments, thanks.
> > >
> > This is already applied, but,
> >
> > Is it required to keep Linux specific features
> > (igb_uio/vfio/kni/vhost..) in base config? Why not move all to Linux
> > only config?
>
> I have no strong opinion.
> Keeping them in the base file makes easy to list every options.
> On the other hand, we already have MPIPE defined only in tilegx config
> and CONTIGEM only in bsdapp.
>
> > Because they show up in final bsd config, which is unnecessary. Also
> > they show up in final Linux config twice, first one disables feature and
> > second one enables back. Although this works fine both for bsd and
> > Linux, it is confusing.
>
I prefer to have them in, so that the base config shows all config options.
Otherwise if a config option only used on one platform suddenly becomes used on
a second one, we need to start patching the base config to move it from a
platform-specific one to a common one. [Or worse, we start having cases where
we have to make a judgement call as to whether something is a common option
or not!]
/Bruce
prev parent reply other threads:[~2016-03-07 12:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 13:53 [dpdk-dev] [PATCH] " Keith Wiles
2016-02-22 15:09 ` Trahe, Fiona
2016-02-22 16:02 ` Wiles, Keith
2016-02-22 16:44 ` Panu Matilainen
2016-02-24 13:58 ` Wiles, Keith
2016-02-24 14:19 ` Trahe, Fiona
2016-02-24 15:25 ` Wiles, Keith
2016-03-03 14:43 ` Wiles, Keith
2016-03-03 17:05 ` Thomas Monjalon
2016-03-03 18:37 ` Thomas Monjalon
2016-03-03 18:47 ` Wiles, Keith
2016-03-04 14:44 ` Wiles, Keith
2016-03-04 15:26 ` Thomas Monjalon
2016-03-04 9:28 ` Traynor, Kevin
2016-03-04 9:39 ` Panu Matilainen
2016-03-04 9:58 ` Traynor, Kevin
2016-03-04 10:28 ` Thomas Monjalon
2016-03-04 14:11 ` Wiles, Keith
2016-03-04 9:35 ` Panu Matilainen
2016-03-04 10:12 ` Panu Matilainen
2016-03-04 14:12 ` Wiles, Keith
2016-03-04 17:01 ` [dpdk-dev] [PATCH v2] " Keith Wiles
2016-03-04 17:26 ` Thomas Monjalon
2016-03-04 18:07 ` Wiles, Keith
2016-03-04 18:11 ` [dpdk-dev] [PATCH v3] " Keith Wiles
2016-03-04 22:43 ` Thomas Monjalon
2016-03-06 1:11 ` Ferruh Yigit
2016-03-06 1:21 ` [dpdk-dev] [PATCH] config: move Linux only config options from base to Linux config Ferruh Yigit
2016-03-06 9:35 ` [dpdk-dev] [PATCH v3] config: remove duplicate configuration information Thomas Monjalon
2016-03-07 12:41 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307124107.GA16816@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).