From: Bruce Richardson <bruce.richardson@intel.com>
To: "Chen, Jing D" <jing.d.chen@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 00/18] fm10k: update shared code
Date: Tue, 8 Mar 2016 14:53:28 +0000 [thread overview]
Message-ID: <20160308145327.GH8716@bricha3-MOBL3> (raw)
In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D04457344@shsmsx102.ccr.corp.intel.com>
On Tue, Mar 08, 2016 at 02:25:27PM +0000, Chen, Jing D wrote:
> Hi, Xiao
>
> > -----Original Message-----
> > From: Wang, Xiao W
> > Sent: Tuesday, March 8, 2016 8:15 AM
> > To: Richardson, Bruce <bruce.richardson@intel.com>; Chen, Jing D
> > <jing.d.chen@intel.com>
> > Cc: Chen, Jing D <jing.d.chen@intel.com>; dev@dpdk.org; He, Shaopeng
> > <shaopeng.he@intel.com>
> > Subject: RE: [PATCH v3 00/18] fm10k: update shared code
> >
> >
> >
> > > -----Original Message-----
> > > From: Richardson, Bruce
> > > Sent: Tuesday, March 8, 2016 9:24 PM
> > > To: Wang, Xiao W <xiao.w.wang@intel.com>; Chen, Jing D
> > > <jing.d.chen@intel.com>
> > > Cc: Chen, Jing D <jing.d.chen@intel.com>; dev@dpdk.org; He, Shaopeng
> > > <shaopeng.he@intel.com>
> > > Subject: Re: [PATCH v3 00/18] fm10k: update shared code
> > >
> > > On Fri, Feb 19, 2016 at 07:06:47PM +0800, Wang Xiao W wrote:
> > > > v3:
> > > > * Fixed checkpatch.pl warning about long commit message.
> > > > * Fixed the issue of compile failure about part of patches applied.
> > > > * Split the misc-small-fixes patch into several patches.
> > > >
> > > > v2:
> > > > * Put the two extra fix patches ahead of the base code patches.
> > > >
> > > > This patch set has passed regression test.
> > > >
> > > > Wang Xiao W (18):
> > > > fm10k: use default mailbox message handler for PF
> > > > fm10k/base: correct typecast in fm10k_update_xc_addr_pf
> > > > fm10k/base: cleanup namespace pollution
> > > > fm10k/base: use bitshift for itr_scale
> > > > fm10k/base: reset max_queues on init_hw_vf failure
> > > > fm10k/base: document ITR scale workaround in VF TDLEN register
> > > > fm10k/base: cleanup lines over 80 characters
> > > > fm10k/base: cleanup useless else
> > > > fm10k/base: use BIT macro instead of open-coded bit-shifting of 1
> > > > fm10k/base: do not use CamelCase
> > > > fm10k/base: use memcpy for mac addr copy
> > > > fm10k/base: allow removal of is_slot_appropriate function
> > > > fm10k/base: consistently use VLAN ID when referencing vid variables
> > > > fm10k/base: imporve comment per upstream review changes
> > > > fm10k/base: fix TLV structures alignment
> > > > fm10k/base: move constants to the right of binary operators
> > > > fm10k/base: minor cleanups
> > > > fm10k/base: remove unused struct element
> > > >
> > > > drivers/net/fm10k/base/fm10k_api.c | 2 +
> > > > drivers/net/fm10k/base/fm10k_api.h | 2 +
> > > > drivers/net/fm10k/base/fm10k_mbx.c | 63 +++++++-----
> > > > drivers/net/fm10k/base/fm10k_mbx.h | 11 +--
> > > > drivers/net/fm10k/base/fm10k_osdep.h | 32 ++++++
> > > > drivers/net/fm10k/base/fm10k_pf.c | 88 +++++++++--------
> > > > drivers/net/fm10k/base/fm10k_pf.h | 18 ++--
> > > > drivers/net/fm10k/base/fm10k_tlv.c | 40 ++++----
> > > > drivers/net/fm10k/base/fm10k_tlv.h | 9 +-
> > > > drivers/net/fm10k/base/fm10k_type.h | 182 +++++++---------------------
> > -------
> > > > drivers/net/fm10k/base/fm10k_vf.c | 32 ++++--
> > > > drivers/net/fm10k/fm10k_ethdev.c | 41 +++-----
> > > > 12 files changed, 222 insertions(+), 298 deletions(-)
> > > >
> > > > --
> > > > 1.9.3
> > > >
> > > Hi Mark,
> > >
> > > Can we get fm10k maintainer review and/or ack on this patchset please.
> > >
> > > Thanks,
> > > /Bruce
> >
> > Hi Bruce,
> >
> > Mark has reviewed and acked the patch set in v2, and I put the "Acked-by "
> > in the v3 01/18 patch.
> > It's the same for my FTAG patch.
> >
>
> It's better to add acked-by in both patch set and cover letter, this may be more
> helpful for maintainers.
>
An earlier ack should be reflected by putting the ack on all patches of the set
in later revisions. If it's only on patch 1, that implies that only that one patch
has been acked. If the ack is included in the cover letter only, then it's likely
to be missed, as a series ack is expected as a reply to the cover letter (because
as stated above, subsequent revs should include the ack in each patch itself)
/Bruce
next prev parent reply other threads:[~2016-03-08 14:53 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 10:35 [dpdk-dev] [PATCH 00/16] fm10k: update shared code from ND team Wang Xiao W
2016-01-21 10:35 ` [dpdk-dev] [PATCH 01/16] fm10k/base: cleanup namespace pollution and correct typecast Wang Xiao W
2016-01-21 10:35 ` [dpdk-dev] [PATCH 02/16] fm10k/base: use bitshift for itr_scale Wang Xiao W
2016-01-21 10:35 ` [dpdk-dev] [PATCH 03/16] fm10k/base: reset max_queues on init_hw_vf failure Wang Xiao W
2016-01-21 10:35 ` [dpdk-dev] [PATCH 04/16] fm10k/base: document ITR scale workaround in VF TDLEN register Wang Xiao W
2016-01-21 10:35 ` [dpdk-dev] [PATCH 05/16] fm10k/base: fix checkpatch warning Wang Xiao W
2016-01-21 10:35 ` [dpdk-dev] [PATCH 06/16] fm10k/base: use BIT macro instead of open-coded bit-shifting of 1 Wang Xiao W
2016-01-21 10:35 ` [dpdk-dev] [PATCH 07/16] fm10k/base: do not use CamelCase Wang Xiao W
2016-01-21 10:35 ` [dpdk-dev] [PATCH 08/16] fm10k/base: use memcpy for mac addr copy Wang Xiao W
2016-01-21 10:35 ` [dpdk-dev] [PATCH 09/16] fm10k/base: allow removal of is_slot_appropriate function Wang Xiao W
2016-01-21 10:35 ` [dpdk-dev] [PATCH 10/16] fm10k/base: consistently use VLAN ID when referencing vid variables Wang Xiao W
2016-01-21 10:35 ` [dpdk-dev] [PATCH 11/16] fm10k/base: fix comment per upstream review changes Wang Xiao W
2016-01-21 10:35 ` [dpdk-dev] [PATCH 12/16] fm10k/base: TLV structures must be 4byte aligned, not 1byte aligned Wang Xiao W
2016-01-21 10:35 ` [dpdk-dev] [PATCH 13/16] fm10k/base: move constants to the right of binary operators Wang Xiao W
2016-01-21 10:35 ` [dpdk-dev] [PATCH 14/16] fm10k/base: minor cleanups Wang Xiao W
2016-01-21 10:36 ` [dpdk-dev] [PATCH 15/16] fm10k: use default mailbox message handler for pf Wang Xiao W
2016-01-22 21:31 ` Bruce Richardson
2016-01-25 2:31 ` Wang, Xiao W
2016-01-26 20:16 ` Bruce Richardson
2016-01-27 1:57 ` Wang, Xiao W
2016-01-27 3:50 ` [dpdk-dev] [PATCH v2 00/16] fm10k: update shared code Wang Xiao W
2016-01-27 3:50 ` [dpdk-dev] [PATCH v2 01/16] fm10k: use default mailbox message handler for pf Wang Xiao W
2016-02-16 10:50 ` Bruce Richardson
2016-02-18 10:25 ` Wang, Xiao W
2016-02-19 11:06 ` [dpdk-dev] [PATCH v3 00/18] fm10k: update shared code Wang Xiao W
2016-02-19 11:06 ` [dpdk-dev] [PATCH v3 01/18] fm10k: use default mailbox message handler for PF Wang Xiao W
2016-02-19 11:06 ` [dpdk-dev] [PATCH v3 02/18] fm10k/base: correct typecast in fm10k_update_xc_addr_pf Wang Xiao W
2016-02-19 11:06 ` [dpdk-dev] [PATCH v3 03/18] fm10k/base: cleanup namespace pollution Wang Xiao W
2016-02-19 11:06 ` [dpdk-dev] [PATCH v3 04/18] fm10k/base: use bitshift for itr_scale Wang Xiao W
2016-02-19 11:06 ` [dpdk-dev] [PATCH v3 05/18] fm10k/base: reset max_queues on init_hw_vf failure Wang Xiao W
2016-02-19 11:06 ` [dpdk-dev] [PATCH v3 06/18] fm10k/base: document ITR scale workaround in VF TDLEN register Wang Xiao W
2016-02-19 11:06 ` [dpdk-dev] [PATCH v3 07/18] fm10k/base: cleanup lines over 80 characters Wang Xiao W
2016-02-19 11:06 ` [dpdk-dev] [PATCH v3 08/18] fm10k/base: cleanup useless else Wang Xiao W
2016-02-19 11:06 ` [dpdk-dev] [PATCH v3 09/18] fm10k/base: use BIT macro instead of open-coded bit-shifting of 1 Wang Xiao W
2016-02-19 11:06 ` [dpdk-dev] [PATCH v3 10/18] fm10k/base: do not use CamelCase Wang Xiao W
2016-02-19 11:06 ` [dpdk-dev] [PATCH v3 11/18] fm10k/base: use memcpy for mac addr copy Wang Xiao W
2016-02-19 11:06 ` [dpdk-dev] [PATCH v3 12/18] fm10k/base: allow removal of is_slot_appropriate function Wang Xiao W
2016-02-19 11:07 ` [dpdk-dev] [PATCH v3 13/18] fm10k/base: consistently use VLAN ID when referencing vid variables Wang Xiao W
2016-02-19 11:07 ` [dpdk-dev] [PATCH v3 14/18] fm10k/base: imporve comment per upstream review changes Wang Xiao W
2016-02-19 11:07 ` [dpdk-dev] [PATCH v3 15/18] fm10k/base: fix TLV structures alignment Wang Xiao W
2016-02-19 11:07 ` [dpdk-dev] [PATCH v3 16/18] fm10k/base: move constants to the right of binary operators Wang Xiao W
2016-02-19 11:07 ` [dpdk-dev] [PATCH v3 17/18] fm10k/base: minor cleanups Wang Xiao W
2016-02-19 11:07 ` [dpdk-dev] [PATCH v3 18/18] fm10k/base: remove unused struct element Wang Xiao W
2016-02-29 2:30 ` [dpdk-dev] [PATCH v3 00/18] fm10k: update shared code Ding, HengX
2016-03-08 16:27 ` Bruce Richardson
2016-03-08 13:24 ` Bruce Richardson
2016-03-08 14:15 ` Wang, Xiao W
2016-03-08 14:25 ` Chen, Jing D
2016-03-08 14:32 ` Wang, Xiao W
2016-03-08 14:53 ` Bruce Richardson [this message]
2016-01-27 3:50 ` [dpdk-dev] [PATCH v2 02/16] fm10k/base: add macro definitions that are needed Wang Xiao W
2016-02-16 10:52 ` Bruce Richardson
2016-01-27 3:50 ` [dpdk-dev] [PATCH v2 03/16] fm10k/base: cleanup namespace pollution and correct typecast Wang Xiao W
2016-02-16 10:55 ` Bruce Richardson
2016-01-27 3:50 ` [dpdk-dev] [PATCH v2 04/16] fm10k/base: use bitshift for itr_scale Wang Xiao W
2016-01-27 3:50 ` [dpdk-dev] [PATCH v2 05/16] fm10k/base: reset max_queues on init_hw_vf failure Wang Xiao W
2016-01-27 3:50 ` [dpdk-dev] [PATCH v2 06/16] fm10k/base: document ITR scale workaround in VF TDLEN register Wang Xiao W
2016-01-27 3:50 ` [dpdk-dev] [PATCH v2 07/16] fm10k/base: fix checkpatch warning Wang Xiao W
2016-01-27 3:50 ` [dpdk-dev] [PATCH v2 08/16] fm10k/base: use BIT macro instead of open-coded bit-shifting of 1 Wang Xiao W
2016-01-27 3:50 ` [dpdk-dev] [PATCH v2 09/16] fm10k/base: do not use CamelCase Wang Xiao W
2016-01-27 3:50 ` [dpdk-dev] [PATCH v2 10/16] fm10k/base: use memcpy for mac addr copy Wang Xiao W
2016-01-27 3:50 ` [dpdk-dev] [PATCH v2 11/16] fm10k/base: allow removal of is_slot_appropriate function Wang Xiao W
2016-01-27 3:50 ` [dpdk-dev] [PATCH v2 12/16] fm10k/base: consistently use VLAN ID when referencing vid variables Wang Xiao W
2016-01-27 3:50 ` [dpdk-dev] [PATCH v2 13/16] fm10k/base: fix comment per upstream review changes Wang Xiao W
2016-01-27 3:50 ` [dpdk-dev] [PATCH v2 14/16] fm10k/base: TLV structures must be 4byte aligned, not 1byte aligned Wang Xiao W
2016-01-27 3:50 ` [dpdk-dev] [PATCH v2 15/16] fm10k/base: move constants to the right of binary operators Wang Xiao W
2016-01-27 3:50 ` [dpdk-dev] [PATCH v2 16/16] fm10k/base: minor cleanups Wang Xiao W
2016-02-16 8:11 ` [dpdk-dev] [PATCH v2 00/16] fm10k: update shared code Chen, Jing D
2016-01-21 10:36 ` [dpdk-dev] [PATCH 16/16] fm10k/base: add macro definitions that are needed Wang Xiao W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160308145327.GH8716@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jing.d.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).