From: Bruce Richardson <bruce.richardson@intel.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 5/5] mlx5: add VLAN insertion offload
Date: Fri, 11 Mar 2016 15:24:43 +0000 [thread overview]
Message-ID: <20160311152443.GA12500@bricha3-MOBL3> (raw)
In-Reply-To: <1457015279-3089-6-git-send-email-adrien.mazarguil@6wind.com>
On Thu, Mar 03, 2016 at 03:27:59PM +0100, Adrien Mazarguil wrote:
> From: Yaacov Hazan <yaacovh@mellanox.com>
>
> VLAN insertion is done in software by the PMD by default unless
> CONFIG_RTE_LIBRTE_MLX5_VERBS_VLAN_INSERTION is enabled and Verbs provides
> support for hardware insertion.
>
> When enabled, this option improves performance when VLAN insertion is
> requested, however ConnectX-4 Lx boards cannot take advantage of
> multi-packet send optimizations anymore.
>
> Signed-off-by: Yaacov Hazan <yaacovh@mellanox.com>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> ---
> config/common_linuxapp | 1 +
> doc/guides/nics/mlx5.rst | 9 +++
> doc/guides/rel_notes/release_16_04.rst | 6 ++
> drivers/net/mlx5/Makefile | 9 +++
> drivers/net/mlx5/mlx5_defs.h | 9 +++
> drivers/net/mlx5/mlx5_ethdev.c | 12 ++--
> drivers/net/mlx5/mlx5_rxtx.c | 109 +++++++++++++++++++++++++++------
> drivers/net/mlx5/mlx5_rxtx.h | 13 ++++
> drivers/net/mlx5/mlx5_txq.c | 15 ++++-
> 9 files changed, 158 insertions(+), 25 deletions(-)
>
> diff --git a/config/common_linuxapp b/config/common_linuxapp
> index 7b5e49f..793d262 100644
> --- a/config/common_linuxapp
> +++ b/config/common_linuxapp
> @@ -220,6 +220,7 @@ CONFIG_RTE_LIBRTE_MLX5_DEBUG=n
> CONFIG_RTE_LIBRTE_MLX5_SGE_WR_N=4
> CONFIG_RTE_LIBRTE_MLX5_MAX_INLINE=0
> CONFIG_RTE_LIBRTE_MLX5_TX_MP_CACHE=8
> +CONFIG_RTE_LIBRTE_MLX5_VERBS_VLAN_INSERTION=n
>
New build time configuration options are no longer allowed in DPDK, as they can't
be used in binary distributions and make testing harder. This should be made
a run-time option instead.
/Bruce
next prev parent reply other threads:[~2016-03-11 15:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 18:19 [dpdk-dev] [PATCH 0/4] Implement missing features in mlx5 Adrien Mazarguil
2016-02-22 18:19 ` [dpdk-dev] [PATCH 1/4] mlx5: add callbacks to support link (up / down) changes Adrien Mazarguil
2016-02-22 18:19 ` [dpdk-dev] [PATCH 2/4] mlx5: allow operation in secondary processes Adrien Mazarguil
2016-02-22 18:19 ` [dpdk-dev] [PATCH 3/4] mlx5: add support for HW packet padding Adrien Mazarguil
2016-02-22 18:19 ` [dpdk-dev] [PATCH 4/4] mlx5: add VLAN insertion offload Adrien Mazarguil
2016-03-03 14:27 ` [dpdk-dev] [PATCH v2 0/5] Implement missing features in mlx5 Adrien Mazarguil
2016-03-03 14:27 ` [dpdk-dev] [PATCH v2 1/5] mlx5: add callbacks to support link (up / down) changes Adrien Mazarguil
2016-03-03 14:27 ` [dpdk-dev] [PATCH v2 2/5] mlx5: allow operation in secondary processes Adrien Mazarguil
2016-03-03 14:27 ` [dpdk-dev] [PATCH v2 3/5] mlx5: add RX CRC stripping configuration Adrien Mazarguil
2016-03-03 14:27 ` [dpdk-dev] [PATCH v2 4/5] mlx5: add support for HW packet padding Adrien Mazarguil
2016-03-03 14:27 ` [dpdk-dev] [PATCH v2 5/5] mlx5: add VLAN insertion offload Adrien Mazarguil
2016-03-11 15:24 ` Bruce Richardson [this message]
2016-03-16 13:45 ` Adrien Mazarguil
2016-03-17 15:38 ` [dpdk-dev] [PATCH v3 0/5] Implement missing features in mlx5 Adrien Mazarguil
2016-03-17 15:38 ` [dpdk-dev] [PATCH v3 1/5] mlx5: add callbacks to support link (up / down) changes Adrien Mazarguil
2016-03-17 15:38 ` [dpdk-dev] [PATCH v3 2/5] mlx5: allow operation in secondary processes Adrien Mazarguil
2016-03-17 15:38 ` [dpdk-dev] [PATCH v3 3/5] mlx5: add RX CRC stripping configuration Adrien Mazarguil
2016-03-17 15:38 ` [dpdk-dev] [PATCH v3 4/5] mlx5: add support for HW packet padding Adrien Mazarguil
2016-03-17 15:38 ` [dpdk-dev] [PATCH v3 5/5] mlx5: add VLAN insertion offload Adrien Mazarguil
2016-03-22 16:35 ` [dpdk-dev] [PATCH v3 0/5] Implement missing features in mlx5 Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311152443.GA12500@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).