From: Bruce Richardson <bruce.richardson@intel.com>
To: John Daley <johndale@cisco.com>
Cc: dev@dpdk.org, Nelson Escobar <neescoba@cisco.com>
Subject: Re: [dpdk-dev] [PATCH v2] enic: fix incorrect setting of rx descriptor limit
Date: Tue, 22 Mar 2016 17:32:41 +0000 [thread overview]
Message-ID: <20160322173241.GK20448@bricha3-MOBL3> (raw)
In-Reply-To: <1458326014-30910-1-git-send-email-johndale@cisco.com>
On Fri, Mar 18, 2016 at 11:33:34AM -0700, John Daley wrote:
> From: Nelson Escobar <neescoba@cisco.com>
>
> On initialization, the rq descriptor count was set to the limit
> of the vic. When the requested number of rx descriptors was
> less than this count, enic_alloc_rq() was incorrectly setting
> the count to the lower value. This results in later calls to
> enic_alloc_rq() incorrectly using the lower value as the adapter
> limit.
>
> Signed-off-by: Nelson Escobar <neescoba@cisco.com>
> Fixes: fefed3d1e62c ("enic: new driver")
> Reviewed-by: John Daley <johndale@cisco.com>
Please put the fixes line above the signoffs, not in the middle of them. It just
makes it easier to read. I'll fix this for this patch when applying it.
/Bruce
next prev parent reply other threads:[~2016-03-22 17:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 22:46 [dpdk-dev] [PATCH] enic: don't set enic->config.rq_desc_count in enic_alloc_rq() John Daley
2016-03-18 10:24 ` Bruce Richardson
2016-03-18 18:33 ` [dpdk-dev] [PATCH v2] enic: fix incorrect setting of rx descriptor limit John Daley
2016-03-22 17:32 ` Bruce Richardson [this message]
2016-03-22 17:33 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160322173241.GK20448@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=johndale@cisco.com \
--cc=neescoba@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).