From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix icc compile error
Date: Wed, 23 Mar 2016 12:35:25 -0700 [thread overview]
Message-ID: <20160323123525.09de2b2f@xeon-e3> (raw)
In-Reply-To: <1458755158-16145-1-git-send-email-ferruh.yigit@intel.com>
On Wed, 23 Mar 2016 17:45:58 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> Fixes: 06554d381d97 ("ixgbe: speed up non-vector Tx")
>
> icc (icc (ICC) 16.0.1 20151021) is generating following compile error:
> "
> CC ixgbe_rxtx.o
> .../drivers/net/ixgbe/ixgbe_rxtx.c(153): error #3656: variable
> "free" may be used before its value is set
> (nb_free > 0 && m->pool != free[0]->pool)) {
> ^
> "
>
> Indeed this is a false positive and code is correct.
> "nb_free" check prevents the free[] access before its value set.
>
> But the patch is just for compiler to remove compiler error.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_rxtx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index ff6ddb8..ef1a26f 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -128,7 +128,8 @@ ixgbe_tx_free_bufs(struct ixgbe_tx_queue *txq)
> struct ixgbe_tx_entry *txep;
> uint32_t status;
> int i, nb_free = 0;
> - struct rte_mbuf *m, *free[RTE_IXGBE_TX_MAX_FREE_BUF_SZ];
> + struct rte_mbuf *m;
> + struct rte_mbuf *free[RTE_IXGBE_TX_MAX_FREE_BUF_SZ] = {0};
>
> /* check DD bit on threshold descriptor */
> status = txq->tx_ring[txq->tx_next_dd].wb.status;
Although this fixes a compiler bug, it also introduces a performance hit.
The initialization will generate a string instruct (rep; stosz) and this
stalls the multi-execution unit on many Intel CPU's.
Better to add a override to the Makefile (for icc only and with big comment).
next prev parent reply other threads:[~2016-03-23 19:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 17:45 Ferruh Yigit
2016-03-23 19:35 ` Stephen Hemminger [this message]
2016-03-23 21:26 ` Ferruh Yigit
2016-03-24 17:34 ` [dpdk-dev] [PATCH v2] ixgbe: disable icc compile warning Ferruh Yigit
2016-03-24 17:47 ` Ananyev, Konstantin
2016-03-25 13:57 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323123525.09de2b2f@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).