From: Stephen Hemminger <stephen@networkplumber.org>
To: Aaron Conole <aconole@redhat.com>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>,
Panu Matilainen <pmatilai@redhat.com>, "Lu\,
Wenzhuo" <wenzhuo.lu@intel.com>, dev@dpdk.org, "Richardson\,
Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 2/7] drivers/net/e1000: Suppress misleading indentation warning
Date: Wed, 30 Mar 2016 09:36:53 -0700 [thread overview]
Message-ID: <20160330093653.0d7e1847@xeon-e3> (raw)
In-Reply-To: <f7t60w412mr.fsf_-_@redhat.com>
On Wed, 30 Mar 2016 10:06:36 -0400
Aaron Conole <aconole@redhat.com> wrote:
> The register read/write mphy functions have misleading whitespace around
> the `locked` check. This cleanup merely preserves the existing functionality
> and suppresses future gcc versions' "misleading indentation" warning.
>
> Suggested-by: Panu Matilainen <pmatilai@redhat.com>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
> v2:
> * Changed from "whitespace-only" fix to a functional change
> moving the phy writes into protection of the `if (locked)`
> code
> * Added "Fixes" line.
>
> v3:
> * Instead of changing the code, change to suppress the compiler warning
> when using gcc6+. This was tested with both gcc6 and gcc5 using gnu
> make 4.0 and gnu bash 4.3.42 on a fedora 23 system.
>
> drivers/net/e1000/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/e1000/Makefile b/drivers/net/e1000/Makefile
> index ccd2b7b..f4879e6 100644
> --- a/drivers/net/e1000/Makefile
> +++ b/drivers/net/e1000/Makefile
> @@ -54,6 +54,9 @@ else
> #
> CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter
> CFLAGS_BASE_DRIVER += -Wno-unused-variable
> +ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1)
> +CFLAGS_BASE_DRIVER += -Wno-misleading-indentation
> +endif
> endif
>
> #
NAK, don't do it to the whole file.
Fix the code (best option)
or use a pragma for the small area which is broken for other reasons.
next prev parent reply other threads:[~2016-03-30 16:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 21:37 [dpdk-dev] [PATCH v2 0/7] Various fixes to compile with gcc6 Aaron Conole
2016-03-22 21:37 ` [dpdk-dev] [PATCH v2 1/7] app/test/test: Fix missing brackets Aaron Conole
2016-03-22 21:37 ` [dpdk-dev] [PATCH v2 2/7] drivers/net/e1000: " Aaron Conole
2016-03-23 10:38 ` Thomas Monjalon
2016-03-23 10:41 ` Thomas Monjalon
2016-03-24 0:35 ` Lu, Wenzhuo
2016-03-24 6:54 ` Panu Matilainen
2016-03-30 10:51 ` Thomas Monjalon
2016-03-30 13:14 ` Aaron Conole
2016-03-30 14:06 ` [dpdk-dev] [PATCH v3 2/7] drivers/net/e1000: Suppress misleading indentation warning Aaron Conole
2016-03-30 16:36 ` Stephen Hemminger [this message]
2016-03-30 17:12 ` Thomas Monjalon
2016-03-30 21:48 ` Stephen Hemminger
2016-03-31 0:41 ` Lu, Wenzhuo
2016-03-22 21:37 ` [dpdk-dev] [PATCH v2 3/7] drivers/net/e1000: Fix missing lsc interrupt check brackets Aaron Conole
2016-03-22 21:37 ` [dpdk-dev] [PATCH v2 4/7] drivers/net/ixgbe: Fix vlan filter missing brackets Aaron Conole
2016-03-22 21:37 ` [dpdk-dev] [PATCH v2 5/7] drivers/net/e1000/igb: Signed left shift operator Aaron Conole
2016-03-22 21:37 ` [dpdk-dev] [PATCH v2 6/7] drivers/net/ixgbe: " Aaron Conole
2016-03-22 21:37 ` [dpdk-dev] [PATCH v2 7/7] drivers/net/ixgbe: Fix uninitialized warning Aaron Conole
2016-03-31 15:02 ` [dpdk-dev] [PATCH v2 0/7] Various fixes to compile with gcc6 Thomas Monjalon
2016-04-01 6:07 ` Panu Matilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330093653.0d7e1847@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
--cc=thomas.monjalon@6wind.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).