From: Stephen Hemminger <stephen@networkplumber.org>
To: Lee Roberts <lee.roberts@hpe.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Fix KNI compilation under Wind River Linux 6.0 recent RCPLs.
Date: Wed, 30 Mar 2016 14:50:42 -0700 [thread overview]
Message-ID: <20160330145042.1708ecee@xeon-e3> (raw)
In-Reply-To: <1459361615-6021-1-git-send-email-lee.roberts@hpe.com>
On Wed, 30 Mar 2016 12:13:35 -0600
Lee Roberts <lee.roberts@hpe.com> wrote:
> skb_set_hash() has been backported to recent Wind River Linux 6.0 RCPLs.
> As a result, the corresponding stanza in kcompat.h must be removed.
> Similar patches have already been applied for RHEL, SLES and Ubuntu.
>
> Wind River Linux does not provide convenient macros for kernel version
> identification. Add macros to Makefile to identify the Wind River Linux
> version.
>
> Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
> ---
> lib/librte_eal/linuxapp/kni/Makefile | 8 ++++++++
> lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 13 +++++++++++++
> 2 files changed, 21 insertions(+)
>
> diff --git a/lib/librte_eal/linuxapp/kni/Makefile b/lib/librte_eal/linuxapp/kni/Makefile
> index ac99d3f..6310615 100644
> --- a/lib/librte_eal/linuxapp/kni/Makefile
> +++ b/lib/librte_eal/linuxapp/kni/Makefile
> @@ -51,6 +51,14 @@ UBUNTU_KERNEL_CODE := $(shell echo `grep UTS_RELEASE $(RTE_KERNELDIR)/include/ge
> MODULE_CFLAGS += -D"UBUNTU_KERNEL_CODE=UBUNTU_KERNEL_VERSION($(UBUNTU_KERNEL_CODE))"
> endif
>
> +ifeq ($(shell lsb_release -si 2>/dev/null),wrlinux)
> +WRLINUX_MAJOR := $(shell lsb_release -sr | cut -d. -f1)
> +WRLINUX_MINOR := $(shell lsb_release -sr | cut -d. -f2)
> +WRLINUX_RCPL := $(shell lsb_release -sr | cut -d. -f4)
> +MODULE_CFLAGS += -D"WRLINUX_RELEASE_CODE=WRLINUX_RELEASE_VERSION($(WRLINUX_MAJOR),$(WRLINUX_MINOR))"
> +MODULE_CFLAGS += -D"WRLINUX_RCPL=$(WRLINUX_RCPL)"
> +endif
> +
Do we want to require DPDK to work in the face of every weird vendor
kernel backport. This is a road to nowhere...
One more reason to get kernel drivers upstream.
next prev parent reply other threads:[~2016-03-30 21:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 18:13 Lee Roberts
2016-03-30 21:50 ` Stephen Hemminger [this message]
2016-03-30 22:17 ` Vincent JARDIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330145042.1708ecee@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=lee.roberts@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).