From: Bruce Richardson <bruce.richardson@intel.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org, declan.doherty@intel.com
Subject: Re: [dpdk-dev] [PATCH v3 0/8] L2fwd-crypto fixes/enhancements
Date: Thu, 31 Mar 2016 13:14:18 +0100 [thread overview]
Message-ID: <20160331121417.GA27312@bricha3-MOBL3> (raw)
In-Reply-To: <1459416734-54479-1-git-send-email-pablo.de.lara.guarch@intel.com>
On Thu, Mar 31, 2016 at 10:32:06AM +0100, Pablo de Lara wrote:
> This patches fixes some small issues in L2fwd-crypto
> app and also improves the app, making it more flexible
> (accepting different key sizes)
> and readable (information display improvement).
>
> Series-tested-by: Min Cao <min.cao@intel.com>
>
Hi,
Just some general advice:
When someone is acking/resporting a tested-by for a patch series it's ok to
reply to the patch 0.
However, for subsequent versions of the patchset itself, the acks and tested-bys
should be placed on (all) the patches themselves, not in the cover letter. If
it's in the cover letter, you're forcing the applier of the patch to modify each
one individually to stick on the extra information.
Thanks,
/Bruce
>
> Changes in v3:
>
> - Added missing Tested-by line.
>
> Changes in v2:
>
> - Extended help information
>
> Pablo de Lara (8):
> l2fwd-crypto: add missing new line character in help
> l2fwd-crypto: rename period parameter
> l2fwd-crypto: add missing string initialization
> l2fwd-crypto: fix length of random IV/AAD
> l2fwd-crypto: fix ambiguous input key size
> l2fwd-crypto: clarify key parsing in help
> l2fwd-crypto: use key-value list of supported algorithms
> l2fwd-crypto: extend crypto information
>
> examples/l2fwd-crypto/main.c | 473 ++++++++++++++++++++++++++++------
> lib/librte_cryptodev/rte_crypto_sym.h | 6 +-
> 2 files changed, 402 insertions(+), 77 deletions(-)
>
> --
> 2.5.5
>
next prev parent reply other threads:[~2016-03-31 12:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 13:02 [dpdk-dev] [PATCH 0/7] " Pablo de Lara
2016-03-30 13:02 ` [dpdk-dev] [PATCH 1/7] l2fwd-crypto: add missing new line character in help Pablo de Lara
2016-03-30 13:02 ` [dpdk-dev] [PATCH 2/7] l2fwd-crypto: rename period parameter Pablo de Lara
2016-03-30 13:02 ` [dpdk-dev] [PATCH 3/7] l2fwd-crypto: add missing string initialization Pablo de Lara
2016-03-30 13:02 ` [dpdk-dev] [PATCH 4/7] l2fwd-crypto: fix length of random IV/AAD Pablo de Lara
2016-03-30 13:02 ` [dpdk-dev] [PATCH 5/7] l2fwd-crypto: fix ambiguous input key size Pablo de Lara
2016-03-30 13:02 ` [dpdk-dev] [PATCH 6/7] l2fwd-crypto: use key-value list of supported algorithms Pablo de Lara
2016-03-30 13:02 ` [dpdk-dev] [PATCH 7/7] l2fwd-crypto: extend crypto information Pablo de Lara
2016-03-31 8:53 ` [dpdk-dev] [PATCH 0/7] L2fwd-crypto fixes/enhancements Cao, Min
2016-03-31 9:01 ` [dpdk-dev] [PATCH v2 0/8] " Pablo de Lara
2016-03-31 9:01 ` [dpdk-dev] [PATCH v2 1/8] l2fwd-crypto: add missing new line character in help Pablo de Lara
2016-03-31 9:01 ` [dpdk-dev] [PATCH v2 2/8] l2fwd-crypto: rename period parameter Pablo de Lara
2016-03-31 9:01 ` [dpdk-dev] [PATCH v2 3/8] l2fwd-crypto: add missing string initialization Pablo de Lara
2016-03-31 9:01 ` [dpdk-dev] [PATCH v2 4/8] l2fwd-crypto: fix length of random IV/AAD Pablo de Lara
2016-03-31 9:01 ` [dpdk-dev] [PATCH v2 5/8] l2fwd-crypto: fix ambiguous input key size Pablo de Lara
2016-03-31 9:01 ` [dpdk-dev] [PATCH v2 6/8] l2fwd-crypto: clarify key parsing in help Pablo de Lara
2016-03-31 9:01 ` [dpdk-dev] [PATCH v2 7/8] l2fwd-crypto: use key-value list of supported algorithms Pablo de Lara
2016-03-31 9:01 ` [dpdk-dev] [PATCH v2 8/8] l2fwd-crypto: extend crypto information Pablo de Lara
2016-03-31 9:19 ` [dpdk-dev] [PATCH v2 0/8] L2fwd-crypto fixes/enhancements Thomas Monjalon
2016-03-31 9:33 ` De Lara Guarch, Pablo
2016-03-31 9:32 ` [dpdk-dev] [PATCH v3 " Pablo de Lara
2016-03-31 9:32 ` [dpdk-dev] [PATCH v3 1/8] l2fwd-crypto: add missing new line character in help Pablo de Lara
2016-03-31 9:32 ` [dpdk-dev] [PATCH v3 2/8] l2fwd-crypto: rename period parameter Pablo de Lara
2016-03-31 9:32 ` [dpdk-dev] [PATCH v3 3/8] l2fwd-crypto: add missing string initialization Pablo de Lara
2016-03-31 9:32 ` [dpdk-dev] [PATCH v3 4/8] l2fwd-crypto: fix length of random IV/AAD Pablo de Lara
2016-03-31 9:32 ` [dpdk-dev] [PATCH v3 5/8] l2fwd-crypto: fix ambiguous input key size Pablo de Lara
2016-03-31 9:32 ` [dpdk-dev] [PATCH v3 6/8] l2fwd-crypto: clarify key parsing in help Pablo de Lara
2016-03-31 9:32 ` [dpdk-dev] [PATCH v3 7/8] l2fwd-crypto: use key-value list of supported algorithms Pablo de Lara
2016-03-31 9:32 ` [dpdk-dev] [PATCH v3 8/8] l2fwd-crypto: extend crypto information Pablo de Lara
2016-03-31 12:14 ` Bruce Richardson [this message]
2016-03-31 12:19 ` [dpdk-dev] [PATCH v3 0/8] L2fwd-crypto fixes/enhancements Thomas Monjalon
2016-03-31 12:22 ` Declan Doherty
2016-03-31 20:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331121417.GA27312@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).