From: Bruce Richardson <bruce.richardson@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: "Azarewicz, PiotrX T" <piotrx.t.azarewicz@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1 1/1] ixgbe: fix queue stop
Date: Thu, 21 Apr 2016 15:05:07 +0100 [thread overview]
Message-ID: <20160421140506.GB3808@bricha3-MOBL3> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC090903455895@shsmsx102.ccr.corp.intel.com>
On Fri, Apr 15, 2016 at 01:31:03AM +0000, Lu, Wenzhuo wrote:
> Hi,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Piotr Azarewicz
> > Sent: Thursday, April 14, 2016 6:00 PM
> > To: Zhang, Helin; Ananyev, Konstantin
> > Cc: dev@dpdk.org; Azarewicz, PiotrX T
> > Subject: [dpdk-dev] [PATCH v1 1/1] ixgbe: fix queue stop
> >
> > It should be checked if queue enable bit is clear.
> >
> > CID 13215 : Wrong operator used (CONSTANT_EXPRESSION_RESULT)
> > operator_confusion: txdctl | 33554432 is always 1/true regardless of the values
> > of its operand. This occurs as the logical second operand of '&&'.
> >
> > CID 13216 : Wrong operator used (CONSTANT_EXPRESSION_RESULT)
> > operator_confusion: rxdctl | 33554432 is always 1/true regardless of the values
> > of its operand. This occurs as the logical second operand of '&&'.
> >
> > Coverity issue: 13215
> > Coverity issue: 13216
> > Fixes: 029fd06d40fa ("ixgbe: queue start and stop")
> >
> > Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Sometimes machine is smarter than human :) Thanks Piotr for handling this.
Applied to dpdk-next-net/rel_16_07
/Bruce
prev parent reply other threads:[~2016-04-21 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 9:59 Piotr Azarewicz
2016-04-15 1:31 ` Lu, Wenzhuo
2016-04-21 14:05 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421140506.GB3808@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=piotrx.t.azarewicz@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).