From: Bruce Richardson <bruce.richardson@intel.com>
To: Helin Zhang <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] i40e: fix problematic dereference
Date: Mon, 25 Apr 2016 10:41:01 +0100 [thread overview]
Message-ID: <20160425094100.GA18076@bricha3-MOBL3> (raw)
In-Reply-To: <1461563042-886-1-git-send-email-helin.zhang@intel.com>
On Mon, Apr 25, 2016 at 01:44:02PM +0800, Helin Zhang wrote:
> Fix issue reported by Coverity.
>
> Coverity ID 119267: Dereference before null check.
> Coverity ID 13301: Dereference before null check.
> Coverity ID 13294: Dereference before null check.
> Coverity ID 13299: Dereference before null check.
> Coverity ID 13298: Dereference before null check.
+1 for merging all patches into a single one
> Coverity ID 13265: Missing break in switch.
-1 for sticking in a different fix type into your single patch.
>
> Fixes: 8e109464c022 ("i40e: allow vector Rx and Tx usage")
> Fixes: a778a1fa2e4e ("i40e: set up and initialize flow director")
> Fixes: a778a1fa2e4e ("i40e: set up and initialize flow director")
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
>
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> ---
> drivers/net/i40e/i40e_pf.c | 7 +++----
> drivers/net/i40e/i40e_rxtx.c | 10 +++++++---
> 2 files changed, 10 insertions(+), 7 deletions(-)
>
> v2:
> - Combined all the patches into a single one, as suggested.
> - Remove checking rxq, as it shouldn't be NULL at any time.
Thanks for the V2, but please try and keep the patches logically consistent.
If you have multiple patches fixing the same thing in the one driver, please
keep it in one patch. A fix for a different issue type needs to be in a different
patch. If the fix for one type of issue also causes a second issue of a different
type to be fixed also, please call that out separately in the commit message.
Please also explain how the null checks issues are being fixed, and what the
original issue was.
Regards,
/Bruce
next prev parent reply other threads:[~2016-04-25 9:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 3:42 [dpdk-dev] [PATCH 0/6] fix i40e " Helin Zhang
2016-04-21 3:42 ` [dpdk-dev] [PATCH 1/6] i40e: fix " Helin Zhang
2016-04-21 16:10 ` Stephen Hemminger
2016-04-22 1:04 ` Zhang, Helin
2016-04-21 3:42 ` [dpdk-dev] [PATCH 2/6] " Helin Zhang
2016-04-21 3:42 ` [dpdk-dev] [PATCH 3/6] " Helin Zhang
2016-04-21 3:42 ` [dpdk-dev] [PATCH 4/6] " Helin Zhang
2016-04-21 3:42 ` [dpdk-dev] [PATCH 5/6] " Helin Zhang
2016-04-21 3:42 ` [dpdk-dev] [PATCH 6/6] " Helin Zhang
2016-04-21 10:06 ` [dpdk-dev] [PATCH 0/6] fix i40e " Thomas Monjalon
2016-04-21 12:49 ` Zhang, Helin
2016-04-21 12:51 ` Thomas Monjalon
2016-04-21 11:01 ` Bruce Richardson
2016-04-21 12:50 ` Zhang, Helin
2016-04-25 5:44 ` [dpdk-dev] [PATCH v2] i40e: fix " Helin Zhang
2016-04-25 9:41 ` Bruce Richardson [this message]
2016-04-28 3:17 ` [dpdk-dev] [PATCH v3 0/2] fix Coverity reported issues Helin Zhang
2016-04-28 3:17 ` [dpdk-dev] [PATCH v3 1/2] i40e: fix problematic dereference Helin Zhang
2016-04-28 3:17 ` [dpdk-dev] [PATCH v3 2/2] i40e: fix missing break in switch Helin Zhang
2016-06-26 15:46 ` [dpdk-dev] [PATCH v2 0/2] fix coverity issues Helin Zhang
2016-06-26 15:46 ` [dpdk-dev] [PATCH v2 1/2] i40e: fix problematic dereference Helin Zhang
2016-06-26 20:04 ` Mcnamara, John
2016-06-26 15:46 ` [dpdk-dev] [PATCH v2 2/2] i40e: fix missing break in switch Helin Zhang
2016-06-26 20:04 ` Mcnamara, John
2016-06-28 12:01 ` [dpdk-dev] [PATCH v2 0/2] fix coverity issues Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425094100.GA18076@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).