From: Yuanhan Liu <yuanhan.liu@intel.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Cc: Panu Matilainen <pmatilai@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Xie, Huawei" <huawei.xie@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [RFC] Link ibrte_vhost to librte_pmd_vhost
Date: Mon, 25 Apr 2016 22:48:44 -0700 [thread overview]
Message-ID: <20160426054844.GF7832@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <571EFEA1.5080006@igel.co.jp>
On Tue, Apr 26, 2016 at 02:37:37PM +0900, Tetsuya Mukawa wrote:
> On 2016/04/26 12:47, Yuanhan Liu wrote:
> > On Mon, Apr 25, 2016 at 12:28:37PM +0300, Panu Matilainen wrote:
> > >
> >>> Another way is applying a below patch.
> >>> --- a/drivers/net/vhost/Makefile
> >>> +++ b/drivers/net/vhost/Makefile
> >>> @@ -38,6 +38,7 @@ LIB = librte_pmd_vhost.a
> >>>
> >>> CFLAGS += -O3
> >>> CFLAGS += $(WERROR_FLAGS)
> >>> +LDLIBS += -lrte_vhost
> >>>
> >>> EXPORT_MAP := rte_pmd_vhost_version.map
> >>>
> >>> This is same way to link libpcap to librte_pmd_pcap.
> >>> What do you think about adding it to vhost PMD?
> >> Yes, this is absolutely the right thing to do.
> >>
> >> Ultimately this should be done for all dependencies in all libraries, but
> >> missing dependencies are even more pronounced in plugins so the sooner this
> >> goes in, the better.
> >>
> >> Acked-by: Panu Matilainen <pmatilai@redhat.com>
> > Panu, thanks for the input.
> >
> > Tetsuya, please submit a formal patch so that I can merge.
> >
> > --yliu
>
> Hi Yuanhan,
>
> Oh sorry, I forgot to add "--in-reply-to" while sending the patch, so
> you may miss it.
> Also the order of Acked-by and Signed-off-by was wrong in above patch.
> So I will send v2 soon.
No worry. I could fix them, and I don't think there is a very strict
rule for both of them :) BTW, FYI, I just found my linux.intel.com
seems to be broken (no idea why), thus I made late response.
(well, I found you just send a v2; I will apply that tomorrow).
--yliu
next prev parent reply other threads:[~2016-04-26 5:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 9:05 Tetsuya Mukawa
2016-04-25 9:28 ` Panu Matilainen
2016-04-25 9:44 ` Tetsuya Mukawa
2016-04-26 3:47 ` Yuanhan Liu
2016-04-26 5:37 ` Tetsuya Mukawa
2016-04-26 5:48 ` Yuanhan Liu [this message]
2016-04-26 6:00 ` Tetsuya Mukawa
2016-04-26 5:39 ` [dpdk-dev] [PATCH v2] vhost: Fix linkage of vhost PMD Tetsuya Mukawa
2016-04-26 9:35 ` Panu Matilainen
2016-04-27 1:38 ` Tetsuya Mukawa
2016-04-27 22:21 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426054844.GF7832@yliu-dev.sh.intel.com \
--to=yuanhan.liu@intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=mukawa@igel.co.jp \
--cc=pmatilai@redhat.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).