DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, huawei.xie@intel.com
Subject: Re: [dpdk-dev] [PATCH v3 1/2] virtio: cleanup virtio_dev_queue_setup()
Date: Wed, 4 May 2016 20:19:31 -0700	[thread overview]
Message-ID: <20160505031931.GV5641@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1461890926-16727-2-git-send-email-jianfeng.tan@intel.com>

On Fri, Apr 29, 2016 at 12:48:45AM +0000, Jianfeng Tan wrote:
> +	if (queue_type < VTNET_RQ || queue_type > VTNET_CQ) {
> +		PMD_INIT_LOG(ERR, "invalid queue type: %d", queue_type);
> +		return -EINVAL;
>  	}

I'm thinking this check is not necessary. We can make sure it's a valid
queue type.

	--yliu

  reply	other threads:[~2016-05-05  3:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26 12:32 [dpdk-dev] [PATCH] virtio: fix memory leak of virtqueue memzones Jianfeng Tan
2016-04-27 22:37 ` Yuanhan Liu
2016-04-28  2:01   ` Tan, Jianfeng
2016-04-28  3:29     ` Yuanhan Liu
2016-04-28 19:03 ` [dpdk-dev] [PATCH v2 0/2] " Jianfeng Tan
2016-04-28 19:04   ` [dpdk-dev] [PATCH v2 1/2] virtio: cleanup virtio_dev_queue_setup() Jianfeng Tan
2016-04-28 19:04   ` [dpdk-dev] [PATCH v2 2/2] virtio: fix memory leak of virtqueue memzones Jianfeng Tan
2016-04-28 19:05   ` [dpdk-dev] [PATCH v2 0/2] " Tan, Jianfeng
2016-04-28 19:08     ` Tan, Jianfeng
2016-04-29  0:48 ` [dpdk-dev] [PATCH v3 " Jianfeng Tan
2016-04-29  0:48   ` [dpdk-dev] [PATCH v3 1/2] virtio: cleanup virtio_dev_queue_setup() Jianfeng Tan
2016-05-05  3:19     ` Yuanhan Liu [this message]
2016-05-09  7:58       ` Tan, Jianfeng
2016-05-09 18:04         ` Yuanhan Liu
2016-04-29  0:48   ` [dpdk-dev] [PATCH v3 2/2] virtio: fix memory leak of virtqueue memzones Jianfeng Tan
2016-04-29  5:33     ` Yuanhan Liu
2016-05-05  3:27       ` Yuanhan Liu
2016-05-05  4:51         ` Tan, Jianfeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160505031931.GV5641@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=dev@dpdk.org \
    --cc=huawei.xie@intel.com \
    --cc=jianfeng.tan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).