From: Bruce Richardson <bruce.richardson@intel.com>
To: John Daley <johndale@cisco.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] enic: fix 'imissed' to count drops due to no RX buffers
Date: Fri, 6 May 2016 15:29:39 +0100 [thread overview]
Message-ID: <20160506142938.GA8880@bricha3-MOBL3> (raw)
In-Reply-To: <1461725415-3899-1-git-send-email-johndale@cisco.com>
On Tue, Apr 26, 2016 at 07:50:15PM -0700, John Daley wrote:
> Fixes: 7182d3e7d177 ("enic: expose Rx missed packets counter")
> Signed-off-by: John Daley <johndale@cisco.com>
> ---
> drivers/net/enic/enic_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
> index 60fe765..be4e9e5 100644
> --- a/drivers/net/enic/enic_main.c
> +++ b/drivers/net/enic/enic_main.c
> @@ -243,10 +243,10 @@ void enic_dev_stats_get(struct enic *enic, struct rte_eth_stats *r_stats)
> r_stats->ibytes = stats->rx.rx_bytes_ok;
> r_stats->obytes = stats->tx.tx_bytes_ok;
>
> - r_stats->ierrors = stats->rx.rx_errors;
> + r_stats->ierrors = stats->rx.rx_errors + stats->rx.rx_drop;
> r_stats->oerrors = stats->tx.tx_errors;
>
> - r_stats->imissed = stats->rx.rx_drop;
> + r_stats->imissed = stats->rx.rx_no_bufs;
>
> r_stats->rx_nombuf = stats->rx.rx_no_bufs;
> }
> --
> 2.7.0
>
I think this patch just needs a little more detail in the commit message to
help explain it. Can you explain what stats->rx.rx_drop is and why it should
be added to ierrors rather than being part of imissed.
Regards,
/Bruce
prev parent reply other threads:[~2016-05-06 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 2:50 John Daley
2016-05-06 14:29 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160506142938.GA8880@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=johndale@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).