From: Bruce Richardson <bruce.richardson@intel.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: dev@dpdk.org, Dept-EngDPDKDev@qlogic.com,
Harish Patil <harish.patil@qlogic.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/3] bnx2x: refactor Tx routine for single doorbell mechanism
Date: Fri, 6 May 2016 15:45:24 +0100 [thread overview]
Message-ID: <20160506144524.GB8880@bricha3-MOBL3> (raw)
In-Reply-To: <1462340302-25683-1-git-send-email-rasesh.mody@qlogic.com>
On Tue, May 03, 2016 at 10:38:20PM -0700, Rasesh Mody wrote:
> Change the Tx routine logic to ring the doorbell once per burst and not
> on every Tx packet. This driver-level optimization is necessary to achieve
> line rates for larger frame sizes (1k or more).
>
> Fixes: 540a211084a7 ("bnx2x: driver core")
>
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> Signed-off-by: Harish Patil <harish.patil@qlogic.com>
Hi Rasesh, Harish,
there is quite a bit of churn to the tx_encap routine in this patch, but the
reason for that function change is not really explained well here - why it's
changed from a burst function to a single mbuf function. This is confusing when
the overall objective of the patch seems to be to do the opposite - have things
more burst oriented.
It might be better to have this patch split into two patches - one changing the
tx_encap function and then a second one to restructure the xmit function.
Regards,
/Bruce
next prev parent reply other threads:[~2016-05-06 14:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 5:38 Rasesh Mody
2016-05-04 5:38 ` [dpdk-dev] [PATCH v4 2/3] bnx2x: enhance stats get Rasesh Mody
2016-05-06 14:47 ` Bruce Richardson
2016-05-07 0:14 ` Rasesh Mody
2016-05-10 10:27 ` Remy Horton
2016-05-11 0:58 ` Rasesh Mody
2016-06-21 9:00 ` Remy Horton
2016-05-04 5:38 ` [dpdk-dev] [PATCH v4 3/3] bnx2x: update PMD version to 1.0.1.1 Rasesh Mody
2016-05-06 14:45 ` Bruce Richardson [this message]
2016-05-11 5:41 ` [dpdk-dev] [PATCH v4 1/3] bnx2x: refactor Tx routine for single doorbell mechanism Harish Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160506144524.GB8880@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=Dept-EngDPDKDev@qlogic.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
--cc=rasesh.mody@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).