From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, Tetsuya Mukawa <mukawa@igel.co.jp>,
Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] vhost: add support for dynamic vhost PMD creation
Date: Fri, 20 May 2016 11:37:47 +0100 [thread overview]
Message-ID: <20160520103746.GA19260@bricha3-MOBL3> (raw)
In-Reply-To: <1891939.OmQDtN0y3O@xps13>
On Thu, May 19, 2016 at 06:44:44PM +0200, Thomas Monjalon wrote:
> 2016-05-19 17:28, Ferruh Yigit:
> > On 5/19/2016 9:33 AM, Thomas Monjalon wrote:
> > > 2016-05-18 18:10, Ferruh Yigit:
> > >> Add rte_eth_from_vhost() API to create vhost PMD dynamically from
> > >> applications.
> > >
> > > How is it different from rte_eth_dev_attach() calling rte_eal_vdev_init()?
> > >
> >
> > When used rte_eth_dev_attach(), application also needs to do:
> > rte_eth_dev_configure()
> > rte_eth_rx_queue_setup()
> > rte_eth_tx_queue_setup()
> > rte_eth_dev_start()
> >
> > rte_eth_from_vhost() does these internally, easier to use for applications.
>
> This argument is not sufficient.
> We are not going to add new APIs just for wrapping others.
Why not - if there is a sufficient increase in developer usability by doing so?
Having one API that saves an app from having to call 5 other APIs looks like
something that should always be given fair consideration. There will obviously
be other factors to take into account too, like numbers and types of parameters
to the replacement call vs the sub-calls, but I don't think a blanket ban is
justified.
Regards,
/Bruce
next prev parent reply other threads:[~2016-05-20 10:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 18:11 [dpdk-dev] [PATCH] " Ferruh Yigit
2016-05-09 21:31 ` Yuanhan Liu
2016-05-10 17:11 ` Ferruh Yigit
2016-05-18 17:10 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2016-05-19 8:33 ` Thomas Monjalon
2016-05-19 16:28 ` Ferruh Yigit
2016-05-19 16:44 ` Thomas Monjalon
2016-05-20 1:59 ` Yuanhan Liu
2016-05-20 10:37 ` Bruce Richardson [this message]
2016-05-20 12:03 ` Thomas Monjalon
2016-05-23 13:24 ` Yuanhan Liu
2016-05-23 17:06 ` Ferruh Yigit
2016-05-24 5:11 ` Yuanhan Liu
2016-05-24 9:42 ` Bruce Richardson
2016-05-25 4:41 ` Yuanhan Liu
2016-05-25 11:54 ` Thomas Monjalon
2016-05-26 7:58 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160520103746.GA19260@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=mukawa@igel.co.jp \
--cc=thomas.monjalon@6wind.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).