From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, Tetsuya Mukawa <mukawa@igel.co.jp>,
david.marchand@6wind.com
Subject: Re: [dpdk-dev] [PATCH v2] vhost: add support for dynamic vhost PMD creation
Date: Thu, 26 May 2016 15:58:56 +0800 [thread overview]
Message-ID: <20160526075856.GV5641@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <3536324.AAsUjNi441@xps13>
On Wed, May 25, 2016 at 01:54:41PM +0200, Thomas Monjalon wrote:
> > OTOH, let's assume there is a switch that supports quite many such
> > vdevs, as well as the ability to add a new device dynamically by
> > corresponding API. And assume there is just one external interface
> > from the switch to add a dynamical device (say, "ovs-vsctl add-port"),
> > you then also need build some codes to invoke the right API, as well
> > as constructing the right parameters, like what you said below.
> >
> > This let me think of the vhost dequeue/enqueue API. Basically speaking,
> > it has the same functionality the rte_eth_rx/tx_burst has, but just
> > different API name and different parameters. This results to OVS has
> > to write different netdev_class, one for NIC, another one for vhost-user.
> > (actually, there is yet another one for vhost-cuse).
> >
> > And now since we have vhost-pmd, we could just have one netdev_class
> > at OVS, saving their (and other application's) effort to build/maintain
> > similar codes.
>
> Yes, it was a good improvement.
Yeah, kudos to Tetsuya.
> > Thus, I'm __just wondering__ could we add a generic interface to create
> > vdev dynamically for all such vdevs? I was thinking something like:
> >
> > rte_create_vdev(type, char *options);
>
> Actually, it has more sense to first create the device with an attach()
> function and the configure it with devargs.
> So neither attaching nor configuring are specific to vdev.
> And devargs configuration can happen long after creating the device object.
>
> I suggest to reject this patch and continue the EAL rework initiated
> by David.
I'm okay with that: I think it's better to use current interface
instead of adding a new one that will be refactored soon.
--yliu
prev parent reply other threads:[~2016-05-26 7:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 18:11 [dpdk-dev] [PATCH] " Ferruh Yigit
2016-05-09 21:31 ` Yuanhan Liu
2016-05-10 17:11 ` Ferruh Yigit
2016-05-18 17:10 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2016-05-19 8:33 ` Thomas Monjalon
2016-05-19 16:28 ` Ferruh Yigit
2016-05-19 16:44 ` Thomas Monjalon
2016-05-20 1:59 ` Yuanhan Liu
2016-05-20 10:37 ` Bruce Richardson
2016-05-20 12:03 ` Thomas Monjalon
2016-05-23 13:24 ` Yuanhan Liu
2016-05-23 17:06 ` Ferruh Yigit
2016-05-24 5:11 ` Yuanhan Liu
2016-05-24 9:42 ` Bruce Richardson
2016-05-25 4:41 ` Yuanhan Liu
2016-05-25 11:54 ` Thomas Monjalon
2016-05-26 7:58 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160526075856.GV5641@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=mukawa@igel.co.jp \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).