From: Zhe Tao <zhe.tao@intel.com>
To: Jingjing Wu <jingjing.wu@intel.com>
Cc: helin.zhang@intel.com, dev@dpdk.org, mikehabibi@gmail.com
Subject: Re: [dpdk-dev] [PATCH] i40e: fix flexible payload selection
Date: Thu, 2 Jun 2016 03:30:57 +0800 [thread overview]
Message-ID: <20160601193057.GB19593@intel.com> (raw)
In-Reply-To: <1463040700-32165-1-git-send-email-jingjing.wu@intel.com>
On Thu, May 12, 2016 at 04:11:40PM +0800, Jingjing Wu wrote:
> When setting up flexible payload selection rules, it is allowed
> that setting value to 63 to disable the rule (NONUSE_FLX_PIT_DEST_OFF).
> However, MK_FLX_PIT macro is always adding an offset value 50
> (I40E_FLX_OFFSET_IN_FIELD_VECTOR), it will be set to "63 + 50" and
> when setting NONUSE_FLX_PIT_DEST_OFF to disable it. It breaks
> the functionality.
> This patch fixes this issue.
>
> Fixes: d8b90c4eabe9 ("i40e: take flow director flexible payload
> configuration")
>
> Reported-by: Michael Habibi <mikehabibi@gmail.com>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> ---
> drivers/net/i40e/i40e_fdir.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c
> index 8aa41e5..efbcd18 100644
> --- a/drivers/net/i40e/i40e_fdir.c
> +++ b/drivers/net/i40e/i40e_fdir.c
> @@ -94,7 +94,9 @@
> I40E_PRTQF_FLX_PIT_SOURCE_OFF_MASK) | \
> (((fsize) << I40E_PRTQF_FLX_PIT_FSIZE_SHIFT) & \
> I40E_PRTQF_FLX_PIT_FSIZE_MASK) | \
> - ((((dst_offset) + I40E_FLX_OFFSET_IN_FIELD_VECTOR) << \
> + ((((dst_offset) == NONUSE_FLX_PIT_DEST_OFF ? \
> + NONUSE_FLX_PIT_DEST_OFF : \
> + ((dst_offset) + I40E_FLX_OFFSET_IN_FIELD_VECTOR)) << \
> I40E_PRTQF_FLX_PIT_DEST_OFF_SHIFT) & \
> I40E_PRTQF_FLX_PIT_DEST_OFF_MASK))
>
> --
> 2.4.0
Acked-by: Zhe Tao <zhe.tao@intel.com>
next prev parent reply other threads:[~2016-06-02 3:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 8:11 Jingjing Wu
2016-06-01 19:30 ` Zhe Tao [this message]
2016-06-09 9:43 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601193057.GB19593@intel.com \
--to=zhe.tao@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=mikehabibi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).