From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Christian Ehrhardt <christian.ehrhardt@canonical.com>,
Panu Matilainen <pmatilai@redhat.com>,
dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
olivier.matz@6wind.com
Subject: Re: [dpdk-dev] [PATCH] mk: generate internal library dependencies from DEPDIRS-y automatically
Date: Tue, 7 Jun 2016 15:07:16 +0100 [thread overview]
Message-ID: <20160607140715.GC6948@bricha3-MOBL3> (raw)
In-Reply-To: <24422417.UYSFgAybK6@xps13>
On Tue, Jun 07, 2016 at 03:00:45PM +0200, Thomas Monjalon wrote:
> 2016-06-07 14:36, Christian Ehrhardt:
> > But I still struggle to see how to fix the circular dependency between
> > librte_eal and librte_mempool.
>
> Why is there a circular dependency?
> Only because of logs using mempool?
>
> > Maybe now is a time to look at this part of the original threads again to
> > eventually get apps less overlinked?
> > => http://www.dpdk.org/ml/archives/dev/2016-May/039441.html
> > My naive suggestions in generalized form can be found there (no answer yet):
> > =>
> > http://stackoverflow.com/questions/37351699/how-to-create-both-so-files-for-two-circular-depending-libraries
>
> I would prefer removing the circular dependency.
> Maybe we can rewrite the code to not use mempool or move it outside of EAL.
Or else we can take the attitude that the mempools and the rings are just a core
part of DPDK and move them and the EAL into a dpdk_core library at link time.
Having the code separate in the git tree is good, but I'm not sure having
the resulting object files being in separate .a/.so files is particularly useful.
I can't see someone wanting to use one without the other.
/Bruce
next prev parent reply other threads:[~2016-06-07 14:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 10:01 Panu Matilainen
2016-06-07 12:36 ` Christian Ehrhardt
2016-06-07 13:00 ` Thomas Monjalon
2016-06-07 14:07 ` Bruce Richardson [this message]
2016-06-07 14:19 ` Thomas Monjalon
2016-06-07 14:37 ` Bruce Richardson
2016-06-07 14:40 ` Wiles, Keith
2016-06-08 12:34 ` Olivier Matz
2016-06-08 13:38 ` Thomas Monjalon
2016-06-09 9:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607140715.GC6948@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=pmatilai@redhat.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).