From: Bruce Richardson <bruce.richardson@intel.com>
To: Jingjing Wu <jingjing.wu@intel.com>
Cc: helin.zhang@intel.com, dev@dpdk.org, yulong.pei@intel.com,
andrey.chilikin@intel.com
Subject: Re: [dpdk-dev] [PATCH] i40e: fix link management
Date: Wed, 8 Jun 2016 17:39:14 +0100 [thread overview]
Message-ID: <20160608163914.GB10096@bricha3-MOBL3> (raw)
In-Reply-To: <1463037664-31365-1-git-send-email-jingjing.wu@intel.com>
On Thu, May 12, 2016 at 03:21:04PM +0800, Jingjing Wu wrote:
> Previously, there was a known issue "On Intel® 40G Ethernet
> Controller stopping the port does not really down the port link."
> There were two reasons why the port is always kept up.
> 1. Old version Firmware would cause issue when call "Set PHY config
> command" on 40G NIC.
> 2. Because linux kernel i40e driver didn’t call "Set PHY config
> command" when ifconfig up/down, and it assumes the link always up.
> While ports are forced down when DPDK quit. So if the port is switched
> to controlled by kernel driver, the port will not be up through
> "ifconfig <ethx> up".
>
> This patch fixes this issue by reopening "Set PHY config command"
> because:
> 1. New firmware issue is already fixed.
> 2. After DPDK quit, "ethtool -s <ethx> autoneg on" can be used to
> turn on the auto negotiation, and then port can be up through
> "ifconfig <ethx> up" in new version kernel i40e driver( >1.4.X ).
>
> Fixes: 2f1e22817420 ("i40e: skip link control as firmware workaround")
> Fixes: 16c979f9adf2 ("i40e: disable setting of PHY configuration")
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Patch applied to dpdk-next-net/rel_16_07, with some commit message cleanups
applied.
/Bruce
next prev parent reply other threads:[~2016-06-08 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 7:21 Jingjing Wu
2016-06-08 16:39 ` Bruce Richardson [this message]
2016-06-13 1:53 ` Peng, Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608163914.GB10096@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=andrey.chilikin@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=yulong.pei@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).