From: Bruce Richardson <bruce.richardson@intel.com>
To: Jingjing Wu <jingjing.wu@intel.com>
Cc: helin.zhang@intel.com, dev@dpdk.org, yulong.pei@intel.com
Subject: Re: [dpdk-dev] [PATCH] i40e: fix vlan filter in promiscuous mode
Date: Mon, 13 Jun 2016 11:51:43 +0100 [thread overview]
Message-ID: <20160613105143.GF13464@bricha3-MOBL3> (raw)
In-Reply-To: <1464336345-20529-1-git-send-email-jingjing.wu@intel.com>
On Fri, May 27, 2016 at 04:05:45PM +0800, Jingjing Wu wrote:
> Vlan filter didn't work if promiscuous mode is enabled. That is
> because i40e driver uses MAC VLAN table for the l2 filtering and
> internal switch. And the vlan table is disabled by default, till
> the first time to add rule in vlan table.
> This patch fixed this issue to enable vlan filter by using vlan table.
>
> Fixes: 4861cde46116 (i40e: new poll mode driver)
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> ---
Hi Jingjing,
can you please clarify this commit message a little to give a little more detail
on how the current setup stops the feature from working, and how the fix
removes the problem.
Thanks,
/Bruce
next prev parent reply other threads:[~2016-06-13 10:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 8:05 Jingjing Wu
2016-05-30 2:41 ` Peng, Yuan
2016-06-13 10:51 ` Bruce Richardson [this message]
2016-06-14 2:24 ` [dpdk-dev] [PATCH v2] i40e: fix VLAN " Jingjing Wu
2016-06-30 1:25 ` [dpdk-dev] [PATCH v3] " Jingjing Wu
2016-07-04 6:33 ` Zhang, Helin
2016-07-04 13:45 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613105143.GF13464@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=yulong.pei@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).