From: Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, adrien.mazarguil@6wind.com
Subject: Re: [dpdk-dev] [PATCH] mlx: fix compilation with older Glibc
Date: Mon, 20 Jun 2016 11:04:50 +0100 [thread overview]
Message-ID: <20160620100450.GA19416@bricha3-MOBL3> (raw)
In-Reply-To: <20160620092518.GT7621@6wind.com>
On Mon, Jun 20, 2016 at 11:25:18AM +0200, Adrien Mazarguil wrote:
> On Fri, Jun 17, 2016 at 05:29:53PM +0100, Ferruh Yigit wrote:
> > On 6/14/2016 10:22 AM, Adrien Mazarguil wrote:
> > > A missing define in the previous patch causes additional compilation
> > > issues.
> > >
> > > Fixes: 3025206f5060 ("mlx: fix compilation with recent Glibc")
> > >
> > > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> >
> > "older Glibc" or "recent Glibc" can be very hard to trace from git
> > history later.
>
> I wasn't sure about the exact version, it appears to be 2.19 and/or 2.20,
> where _BSD_SOURCE was modified and subsequently removed.
>
> I suggest squashing this patch into the original broken commit ("mlx: fix
> compilation with recent Glibc") if possible, I did not submit a v2 as it is
> already applied on dpdk-next-net.
>
> > Does it make sense to add glibc version info for the failing ones or
> > fixed one?
>
> Depends if we can modify the first commit. If we do, let's squash them
> together before adding version information, otherwise let's modify the
> second one only.
>
> I can submit a v2 that overrides both commits or only the second one, tell
> me what you think is best.
>
> --
While I don't like squashing or modifying already-applied commits on the next
tree, since this is for a compilation issue, I may be able to make an exception.
To evaluate it, please send on the proposed updated commit message for the
combined commits. I assume the code to be squashed is as in this V1 patch.
Regards,
/Bruce
next prev parent reply other threads:[~2016-06-20 10:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 15:09 [dpdk-dev] [PATCH 1/2] mlx: fix compilation with recent Glibc Adrien Mazarguil
2016-06-10 15:09 ` [dpdk-dev] [PATCH 2/2] mlx: regenerate autoconf file automatically Adrien Mazarguil
2016-06-13 12:53 ` [dpdk-dev] [PATCH 1/2] mlx: fix compilation with recent Glibc Bruce Richardson
2016-06-13 13:08 ` Bruce Richardson
2016-06-14 9:22 ` [dpdk-dev] [PATCH] mlx: fix compilation with older Glibc Adrien Mazarguil
2016-06-17 16:29 ` Ferruh Yigit
2016-06-20 9:25 ` Adrien Mazarguil
2016-06-20 10:04 ` Bruce Richardson [this message]
2016-06-20 13:31 ` [dpdk-dev] [PATCH v2] mlx: fix compilation with Glibc 2.20 Adrien Mazarguil
2016-06-20 15:24 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620100450.GA19416@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).