From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: <dev@dpdk.org>, <bruce.richardson@intel.com>,
<pablo.de.lara.guarch@intel.com>, <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add tunnel and port RSS offload types
Date: Wed, 22 Jun 2016 12:45:54 +0530 [thread overview]
Message-ID: <20160622071553.GA9860@localhost.localdomain> (raw)
In-Reply-To: <19576009.SQKuele073@xps13>
On Wed, Jun 22, 2016 at 08:43:52AM +0200, Thomas Monjalon wrote:
> 2016-06-22 09:00, Jerin Jacob:
> > On Tue, Jun 21, 2016 at 11:02:59PM +0200, Thomas Monjalon wrote:
> > > Hi Jerin,
> >
> > Hi Thomas,
> >
> > >
> > > I wanted to push this patch which is now a dependency of ThunderX
> > > but I do not fully understand it.
> > >
> > > 2016-03-31 02:21, Jerin Jacob:
> > > > - added VXLAN, GENEVE and NVGRE tunnel flow types
> > > > - added PORT flow type for accounting physical/virtual
> > > > port or channel number in flow creation
> > > [...]
> > > > --- a/lib/librte_ether/rte_eth_ctrl.h
> > > > +++ b/lib/librte_ether/rte_eth_ctrl.h
> > > > @@ -74,7 +74,11 @@ extern "C" {
> > > > #define RTE_ETH_FLOW_IPV6_EX 15
> > > > #define RTE_ETH_FLOW_IPV6_TCP_EX 16
> > > > #define RTE_ETH_FLOW_IPV6_UDP_EX 17
> > > > -#define RTE_ETH_FLOW_MAX 18
> > > > +#define RTE_ETH_FLOW_PORT 18
> > > > +#define RTE_ETH_FLOW_VXLAN 19
> > > > +#define RTE_ETH_FLOW_GENEVE 20
> > > > +#define RTE_ETH_FLOW_NVGRE 21
> > > > +#define RTE_ETH_FLOW_MAX 22
> > >
> > > Please could you explain more what is PORT flow?
> >
> > For example, a NIC card with two physical port where application
> > configures RTE_ETH_FLOW_IPV4 for both, In that case
> > HW generate same RSS value for a similar IPV4 packet, However, in-case if
> > application want to generate a flow that account physical port also then
> > it can configure with RTE_ETH_FLOW_IPV4 | RTE_ETH_FLOW_PORT.
> >
> > RTE_ETH_FLOW_PORT useful for the case where one physical port assigned for
> > INBOUND traffic and other-one for OUTBOUND traffic etc
>
> OK
>
> > > Does it need a comment in the code?
> > Not sure, commit log has description.
>
> How do you expect the user to understand this new value in the API?
> Users do not check in the git history.
> They use doxygen, headers comments and/or examples.
The reason why I said because none of flow type has comments in the
list. If you think RTE_ETH_FLOW_PORT needs a doxygen comment then I can
add it.
It would be nice some else could add the comments for following,
RTE_ETH_FLOW_RAW,
RTE_ETH_FLOW_L2_PAYLOAD
next prev parent reply other threads:[~2016-06-22 7:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-26 17:55 [dpdk-dev] [PATCH " Jerin Jacob
2016-03-26 17:55 ` [dpdk-dev] [PATCH 2/2] ethdev: add ETH_RSS_RETA_SIZE_256 Jerin Jacob
2016-03-29 11:20 ` [dpdk-dev] [PATCH v2 0/2] New RSS offload flags Jerin Jacob
2016-03-29 11:20 ` [dpdk-dev] [PATCH v2 1/2] ethdev: add tunnel and port RSS offload types Jerin Jacob
2016-03-29 11:26 ` Mcnamara, John
2016-03-29 11:58 ` De Lara Guarch, Pablo
2016-03-30 20:47 ` Jerin Jacob
2016-03-30 20:51 ` [dpdk-dev] [PATCH v3 0/2] New RSS offload flags Jerin Jacob
2016-03-30 20:51 ` [dpdk-dev] [PATCH v3 1/2] ethdev: add tunnel and port RSS offload types Jerin Jacob
2016-04-01 14:04 ` Thomas Monjalon
2016-04-01 14:29 ` Jerin Jacob
2016-06-16 11:46 ` Jerin Jacob
2016-06-21 21:02 ` Thomas Monjalon
2016-06-22 3:30 ` Jerin Jacob
2016-06-22 6:43 ` Thomas Monjalon
2016-06-22 7:15 ` Jerin Jacob [this message]
2016-06-22 7:52 ` Thomas Monjalon
2016-06-22 13:03 ` [dpdk-dev] [PATCH v4 0/2] New RSS offload flags Jerin Jacob
2016-06-22 13:03 ` [dpdk-dev] [PATCH v4 1/2] ethdev: add tunnel and port RSS offload types Jerin Jacob
2016-06-22 15:06 ` Thomas Monjalon
2016-06-22 16:48 ` Jerin Jacob
2016-06-22 13:03 ` [dpdk-dev] [PATCH v4 2/2] ethdev: add ETH_RSS_RETA_SIZE_256 Jerin Jacob
2016-06-22 17:47 ` [dpdk-dev] [PATCH v4 0/2] New RSS offload flags Thomas Monjalon
2016-03-30 20:51 ` [dpdk-dev] [PATCH v3 2/2] ethdev: add ETH_RSS_RETA_SIZE_256 Jerin Jacob
2016-03-29 11:20 ` [dpdk-dev] [PATCH v2 " Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160622071553.GA9860@localhost.localdomain \
--to=jerin.jacob@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).