From: Bruce Richardson <bruce.richardson@intel.com>
To: Nelson Escobar <neescoba@cisco.com>
Cc: dev@dpdk.org, johndale@cisco.com
Subject: Re: [dpdk-dev] [PATCH] enic: fix name of hash table used for enic classifiers
Date: Thu, 23 Jun 2016 12:24:04 +0100 [thread overview]
Message-ID: <20160623112404.GF5024@bricha3-MOBL3> (raw)
In-Reply-To: <1465948348-10333-1-git-send-email-neescoba@cisco.com>
On Tue, Jun 14, 2016 at 04:52:28PM -0700, Nelson Escobar wrote:
> The enic_clsf_init() function is called once per enic instance, but it
> used a static name to create the hash table. Consequently when using
> more than one enic instance, there was a name collision which caused
> errors:
>
> EAL: memzone_reserve_aligned_thread_unsafe():
> memzone<RG_HT_enicpmd_clsf_hash> already exists
> RING: Cannot reserve memory
> HASH: memory allocation failed
> PMD: rte_enic_pmd: Init of hash table for clsf failed.
> Flow director feature will not work
>
> This patch changes the name to be unique per enic instance.
>
> Fixes: fefed3d1e62c ("enic: new driver")
>
> Signed-off-by: Nelson Escobar <neescoba@cisco.com>
> Reviewed-by: John Daley <johndale@cisco.com>
> ---
> drivers/net/enic/enic_clsf.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c
> index edb56e1..2ec77f5 100644
> --- a/drivers/net/enic/enic_clsf.c
> +++ b/drivers/net/enic/enic_clsf.c
> @@ -239,15 +239,16 @@ void enic_clsf_destroy(struct enic *enic)
>
> int enic_clsf_init(struct enic *enic)
> {
> + char clsf_name[RTE_HASH_NAMESIZE];
> struct rte_hash_parameters hash_params = {
> - .name = "enicpmd_clsf_hash",
> + .name = clsf_name,
> .entries = ENICPMD_CLSF_HASH_ENTRIES,
> .key_len = sizeof(struct rte_eth_fdir_filter),
> .hash_func = DEFAULT_HASH_FUNC,
> .hash_func_init_val = 0,
> .socket_id = SOCKET_ID_ANY,
> };
> -
> + sprintf(clsf_name, "enic_clsf_%s", enic->bdf_name);
To avoid buffer overflow it's safer to use snprintf rather than sprintf.
snprintf(clsf_name, sizeof(clsf_name), .... );
/Bruce
> enic->fdir.hash = rte_hash_create(&hash_params);
> memset(&enic->fdir.stats, 0, sizeof(enic->fdir.stats));
> enic->fdir.stats.free = ENICPMD_FDIR_MAX;
> --
> 2.7.0
>
next prev parent reply other threads:[~2016-06-23 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 23:52 Nelson Escobar
2016-06-23 11:24 ` Bruce Richardson [this message]
2016-06-23 23:10 ` [dpdk-dev] [PATCH v2] " Nelson Escobar
2016-06-28 10:12 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160623112404.GF5024@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=johndale@cisco.com \
--cc=neescoba@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).