From: Bruce Richardson <bruce.richardson@intel.com>
To: Jianbo Liu <jianbo.liu@linaro.org>
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
dev@dpdk.org, Thomas Monjalon <thomas.monjalon@6wind.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: use rte_mbuf_prefetch_part2 for cacheline1 access
Date: Fri, 24 Jun 2016 12:04:26 +0100 [thread overview]
Message-ID: <20160624110426.GG13456@bricha3-MOBL3> (raw)
In-Reply-To: <CAP4Qi393Xw3YzS9ikXL0zd7+SHrHVmeWs6JZH8KEYZKGEmt2gQ@mail.gmail.com>
On Mon, Jun 20, 2016 at 11:19:19AM +0800, Jianbo Liu wrote:
> On 17 June 2016 at 22:06, Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote:
> > made second cache line access behavior same as IA
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> > drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
> > index 9c1d124..64a329e 100644
> > --- a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
> > +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
> > @@ -280,10 +280,10 @@ _recv_raw_pkts_vec(struct ixgbe_rx_queue *rxq, struct rte_mbuf **rx_pkts,
> > vst1q_u64((uint64_t *)&rx_pkts[pos + 2], mbp2);
> >
> > if (split_packet) {
> > - rte_prefetch_non_temporal(&rx_pkts[pos]->cacheline1);
> > - rte_prefetch_non_temporal(&rx_pkts[pos + 1]->cacheline1);
> > - rte_prefetch_non_temporal(&rx_pkts[pos + 2]->cacheline1);
> > - rte_prefetch_non_temporal(&rx_pkts[pos + 3]->cacheline1);
> > + rte_mbuf_prefetch_part2(rx_pkts[pos]);
> > + rte_mbuf_prefetch_part2(rx_pkts[pos + 1]);
> > + rte_mbuf_prefetch_part2(rx_pkts[pos + 2]);
> > + rte_mbuf_prefetch_part2(rx_pkts[pos + 3]);
> > }
> >
> > /* D.1 pkt 3,4 convert format from desc to pktmbuf */
> > --
> > 2.5.5
> >
>
> Reviewed-by: Jianbo Liu <jianbo.liu@linaro.org>
Applied to dpdk-next-net/rel_16_07
/Bruce
prev parent reply other threads:[~2016-06-24 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 14:06 Jerin Jacob
2016-06-20 3:19 ` Jianbo Liu
2016-06-24 11:04 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624110426.GG13456@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianbo.liu@linaro.org \
--cc=konstantin.ananyev@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).