From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Xie, Huawei" <huawei.xie@intel.com>
Subject: Re: [dpdk-dev] [PATCH 0/3] vhost coverity issue fixes
Date: Fri, 1 Jul 2016 09:56:12 +0800 [thread overview]
Message-ID: <20160701015612.GL2831@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2025899FD@IRSMSX103.ger.corp.intel.com>
On Thu, Jun 30, 2016 at 03:58:31PM +0000, Mcnamara, John wrote:
> > -----Original Message-----
> > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> > Sent: Tuesday, June 28, 2016 4:58 AM
> > To: dev@dpdk.org
> > Cc: Xie, Huawei <huawei.xie@intel.com>; Mcnamara, John
> > <john.mcnamara@intel.com>; Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > Subject: [PATCH 0/3] vhost coverity issue fixes
> >
> > This is a small series fixes 3 coverity issues.
> >
> > John, I'm wondering maybe maybe we could add the next-net and next-virtio
> > tree into the coverity test as well? So that we could catch those errors
> > as earlier as possible, say, at least before they got merged into
> > mainline.
>
> Hi Yuanhan,
>
> Good suggestion. I can do that.
John, Great!
> Are there any additional configs that should
> be enabled? Currently the check runs with:
>
> CONFIG_RTE_LIBRTE_PMD_PCAP=y
> CONFIG_RTE_LIBRTE_PMD_QAT=y
> CONFIG_RTE_LIBRTE_PMD_AESNI_MB=y
> CONFIG_RTE_LIBRTE_PMD_AESNI_GCM=y
> CONFIG_RTE_LIBRTE_PMD_SNOW3G=y
Non of them are related to vhost/virtio, thus we may don't need them
for next-virtio tree. And I just think of one that should be enabled:
CONFIG_RTE_LIBRTE_VHOST_NUMA=y
OTOH, I'm wondering is it worth to enable those debug options, to cover
more codes?
One more question: will it cover all branches? I have 2 branches there,
master and for-testing. It would be great if the coverity test can cover
the two branches. However, it does not matter at all if it just covers
one branch only: master.
Thanks.
--yliu
next prev parent reply other threads:[~2016-07-01 1:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 3:58 Yuanhan Liu
2016-06-28 3:58 ` [dpdk-dev] [PATCH 1/3] vhost: fix memory leak Yuanhan Liu
2016-06-28 3:58 ` [dpdk-dev] [PATCH 2/3] vhost: fix not null terminated string Yuanhan Liu
2016-06-28 3:58 ` [dpdk-dev] [PATCH 3/3] vhost: fix potential NULL pointer dereference Yuanhan Liu
2016-06-30 15:58 ` [dpdk-dev] [PATCH 0/3] vhost coverity issue fixes Mcnamara, John
2016-07-01 1:56 ` Yuanhan Liu [this message]
2016-07-01 2:00 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160701015612.GL2831@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=john.mcnamara@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).