From: Bruce Richardson <bruce.richardson@intel.com>
To: Beilei Xing <beilei.xing@intel.com>
Cc: jingjing.wu@intel.com, michalx.k.jastrzebski@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/3] i40e: fix log error
Date: Tue, 5 Jul 2016 14:24:21 +0100 [thread overview]
Message-ID: <20160705132420.GA23500@bricha3-MOBL3> (raw)
In-Reply-To: <1467699005-16235-2-git-send-email-beilei.xing@intel.com>
On Tue, Jul 05, 2016 at 02:10:03PM +0800, Beilei Xing wrote:
> The condition, "(pf->flags | I40E_FLAG_VMDQ)" will always be true,
> regardless of the value of the flags operand, because I40E_FLAG_VMDQ
> is 4ULL - meaning at least one bit will always be set in the result.
> That will cause log error when VMDq is disabled.
> Since the original intent behind the condition is to check if VMDq
> is enabled, fix the code by changing "|" to "&".
>
> Coverity issue: 13219, 13221
>
> Fixes: 4805ed59e957 ("i40e: enhance mac address operations")
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2016-07-05 13:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 7:34 [dpdk-dev] [PATCH 0/4] i40e: fix coverity defects Beilei Xing
2016-07-04 13:58 ` Bruce Richardson
2016-07-05 1:47 ` Xing, Beilei
2016-07-05 6:10 ` [dpdk-dev] [PATCH v2 0/3] " Beilei Xing
2016-07-05 6:10 ` [dpdk-dev] [PATCH v2 1/3] i40e: fix log error Beilei Xing
2016-07-05 13:24 ` Bruce Richardson [this message]
2016-07-05 6:10 ` [dpdk-dev] [PATCH v2 2/3] i40e: fix dereference before null check Beilei Xing
2016-07-05 13:24 ` Bruce Richardson
2016-07-05 6:10 ` [dpdk-dev] [PATCH v2 3/3] i40e: fix out-of-bounds access Beilei Xing
2016-07-05 13:26 ` Bruce Richardson
2016-07-06 2:00 ` Xing, Beilei
2016-07-08 15:23 ` Bruce Richardson
2016-07-08 15:33 ` [dpdk-dev] [PATCH v2 0/3] fix coverity defects Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705132420.GA23500@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=michalx.k.jastrzebski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).