From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 07/11] pmdinfogen: fix build warnings
Date: Thu, 7 Jul 2016 13:55:27 -0400 [thread overview]
Message-ID: <20160707175527.GN26064@hmsreliant.think-freely.org> (raw)
In-Reply-To: <1467905790-10597-8-git-send-email-thomas.monjalon@6wind.com>
On Thu, Jul 07, 2016 at 05:36:26PM +0200, Thomas Monjalon wrote:
> When compiled with a standard clang, pmdinfogen can raise a warning:
> buildtools/pmdinfogen/pmdinfogen.c:365:1: warning:
> control reaches end of non-void function
>
> Actually there can be more warnings with stricter compilers.
> In order to catch them early and fix most of them, the DPDK standard flags
> WERROR_FLAGS are used.
>
> The warnings fixed are:
> no previous prototype for ...
> no return statement in function returning non-void
> variable ‘secstrings’ set but not used
> ‘sec_name’ defined but not used
> ‘get_symbol_index’ defined but not used
> pointer of type ‘void *’ used in arithmetic
>
> Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility")
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
I'm not opposed to any of these changes, but I'm really starting to wonder how
well used/maintained clang is as a toolchain target. I assert that because,
with my admittedly broken dependency rule, a native clang build for me errors
out in any number of places:
/home/nhorman/git/dpdk/lib/librte_eal/linuxapp/eal/eal_pci.c:392:37: error:
equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
if (((&pci_device_list)->tqh_first == ((void*)0))) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
/home/nhorman/git/dpdk/lib/librte_eal/linuxapp/eal/eal_pci.c:392:37: note:
remove extraneous parentheses around the comparison to silence this warning
if (((&pci_device_list)->tqh_first == ((void*)0))) {
~ ^ ~
/home/nhorman/git/dpdk/lib/librte_eal/linuxapp/eal/eal_pci.c:392:37: note: use
'=' to turn this equality comparison into an assignment
if (((&pci_device_list)->tqh_first == ((void*)0))) {
along with several others
...
The above are (in part) asserted based on the definition of the TAILQ_EMPTY macro which is
from glibc, and has been unchanged for a number of years. This error occurs on
clang 3.7.0 for me. Not saying we can't fix these warnings your getting, but if
clang has been tripping over the above for I don't know how long, I have to
question how important clang is.
Neil
> buildtools/pmdinfogen/Makefile | 4 +--
> buildtools/pmdinfogen/pmdinfogen.c | 58 ++++++++++++--------------------------
> 2 files changed, 20 insertions(+), 42 deletions(-)
>
> diff --git a/buildtools/pmdinfogen/Makefile b/buildtools/pmdinfogen/Makefile
> index 125901b..3885d3b 100644
> --- a/buildtools/pmdinfogen/Makefile
> +++ b/buildtools/pmdinfogen/Makefile
> @@ -41,9 +41,9 @@ HOSTAPP = pmdinfogen
> #
> SRCS-y += pmdinfogen.c
>
> -HOST_EXTRA_CFLAGS += -g -I${RTE_OUTPUT}/include
> +HOST_CFLAGS += $(WERROR_FLAGS) -g
> +HOST_CFLAGS += -I$(RTE_OUTPUT)/include
>
> DEPDIRS-y += lib/librte_eal
>
> include $(RTE_SDK)/mk/rte.hostapp.mk
> -
> diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c
> index 0947dc6..beb06f1 100644
> --- a/buildtools/pmdinfogen/pmdinfogen.c
> +++ b/buildtools/pmdinfogen/pmdinfogen.c
> @@ -15,6 +15,7 @@
> #include <limits.h>
> #include <stdbool.h>
> #include <errno.h>
> +#include <rte_common.h>
> #include "pmdinfogen.h"
>
> #ifdef RTE_ARCH_64
> @@ -32,7 +33,7 @@ static const char *sym_name(struct elf_info *elf, Elf_Sym *sym)
> return "(unknown)";
> }
>
> -void *grab_file(const char *filename, unsigned long *size)
> +static void *grab_file(const char *filename, unsigned long *size)
> {
> struct stat st;
> void *map = MAP_FAILED;
> @@ -59,7 +60,7 @@ failed:
> * spaces in the beginning of the line is trimmed away.
> * Return a pointer to a static buffer.
> **/
> -void release_file(void *file, unsigned long size)
> +static void release_file(void *file, unsigned long size)
> {
> munmap(file, size);
> }
> @@ -67,9 +68,8 @@ void release_file(void *file, unsigned long size)
>
> static void *get_sym_value(struct elf_info *info, const Elf_Sym *sym)
> {
> - void *ptr = (void *)info->hdr + info->sechdrs[sym->st_shndx].sh_offset;
> -
> - return (void *)(ptr + sym->st_value);
> + return RTE_PTR_ADD(info->hdr,
> + info->sechdrs[sym->st_shndx].sh_offset + sym->st_value);
> }
>
> static Elf_Sym *find_sym_in_symtab(struct elf_info *info,
> @@ -95,7 +95,6 @@ static int parse_elf(struct elf_info *info, const char *filename)
> Elf_Ehdr *hdr;
> Elf_Shdr *sechdrs;
> Elf_Sym *sym;
> - const char *secstrings;
> int endian;
> unsigned int symtab_idx = ~0U, symtab_shndx_idx = ~0U;
>
> @@ -140,7 +139,7 @@ static int parse_elf(struct elf_info *info, const char *filename)
> hdr->e_shnum = TO_NATIVE(endian, 16, hdr->e_shnum);
> hdr->e_shstrndx = TO_NATIVE(endian, 16, hdr->e_shstrndx);
>
> - sechdrs = (void *)hdr + hdr->e_shoff;
> + sechdrs = RTE_PTR_ADD(hdr, hdr->e_shoff);
> info->sechdrs = sechdrs;
>
> /* Check if file offset is correct */
> @@ -191,7 +190,6 @@ static int parse_elf(struct elf_info *info, const char *filename)
> TO_NATIVE(endian, ADDR_SIZE, sechdrs[i].sh_entsize);
> }
> /* Find symbol table. */
> - secstrings = (void *)hdr + sechdrs[info->secindex_strings].sh_offset;
> for (i = 1; i < info->num_sections; i++) {
> int nobits = sechdrs[i].sh_type == SHT_NOBITS;
>
> @@ -206,22 +204,22 @@ static int parse_elf(struct elf_info *info, const char *filename)
> if (sechdrs[i].sh_type == SHT_SYMTAB) {
> unsigned int sh_link_idx;
> symtab_idx = i;
> - info->symtab_start = (void *)hdr +
> - sechdrs[i].sh_offset;
> - info->symtab_stop = (void *)hdr +
> - sechdrs[i].sh_offset + sechdrs[i].sh_size;
> + info->symtab_start = RTE_PTR_ADD(hdr,
> + sechdrs[i].sh_offset);
> + info->symtab_stop = RTE_PTR_ADD(hdr,
> + sechdrs[i].sh_offset + sechdrs[i].sh_size);
> sh_link_idx = sechdrs[i].sh_link;
> - info->strtab = (void *)hdr +
> - sechdrs[sh_link_idx].sh_offset;
> + info->strtab = RTE_PTR_ADD(hdr,
> + sechdrs[sh_link_idx].sh_offset);
> }
>
> /* 32bit section no. table? ("more than 64k sections") */
> if (sechdrs[i].sh_type == SHT_SYMTAB_SHNDX) {
> symtab_shndx_idx = i;
> - info->symtab_shndx_start = (void *)hdr +
> - sechdrs[i].sh_offset;
> - info->symtab_shndx_stop = (void *)hdr +
> - sechdrs[i].sh_offset + sechdrs[i].sh_size;
> + info->symtab_shndx_start = RTE_PTR_ADD(hdr,
> + sechdrs[i].sh_offset);
> + info->symtab_shndx_stop = RTE_PTR_ADD(hdr,
> + sechdrs[i].sh_offset + sechdrs[i].sh_size);
> }
> }
> if (!info->symtab_start)
> @@ -262,28 +260,6 @@ static void parse_elf_finish(struct elf_info *info)
> }
> }
>
> -static const char *sec_name(struct elf_info *elf, int secindex)
> -{
> - Elf_Shdr *sechdrs = elf->sechdrs;
> - return (void *)elf->hdr +
> - elf->sechdrs[elf->secindex_strings].sh_offset +
> - sechdrs[secindex].sh_name;
> -}
> -
> -static int get_symbol_index(struct elf_info *info, Elf_Sym *sym)
> -{
> - const char *name = sym_name(info, sym);
> - const char *idx;
> -
> - idx = name;
> - while (idx) {
> - if (isdigit(*idx))
> - return atoi(idx);
> - idx++;
> - }
> - return -1;
> -}
> -
> struct opt_tag {
> const char *suffix;
> const char *json_id;
> @@ -362,6 +338,8 @@ static int locate_pmd_entries(struct elf_info *info)
> }
> }
> } while (last);
> +
> + return 0;
> }
>
> static void output_pmd_info_string(struct elf_info *info, char *outfile)
> --
> 2.7.0
>
>
next prev parent reply other threads:[~2016-07-07 17:55 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 15:36 [dpdk-dev] [PATCH 00/11] additions to pmdinfogen Thomas Monjalon
2016-07-07 15:36 ` [dpdk-dev] [PATCH 01/11] drivers: fix build with new register macro Thomas Monjalon
2016-07-07 15:50 ` Neil Horman
2016-07-07 16:20 ` Adrien Mazarguil
2016-07-07 15:36 ` [dpdk-dev] [PATCH 02/11] crypto: fix parameters registration Thomas Monjalon
2016-07-07 15:53 ` Neil Horman
2016-07-07 15:36 ` [dpdk-dev] [PATCH 03/11] mk: fix build dependency of drivers on pmdinfogen Thomas Monjalon
2016-07-07 15:56 ` Neil Horman
2016-07-07 16:21 ` Thomas Monjalon
2016-07-07 17:44 ` Neil Horman
2016-07-07 15:36 ` [dpdk-dev] [PATCH 04/11] mk: remove traces of hostapp build directory Thomas Monjalon
2016-07-07 16:02 ` Neil Horman
2016-07-07 15:36 ` [dpdk-dev] [PATCH 05/11] mk: fix driver build with installed SDK Thomas Monjalon
2016-07-07 15:36 ` [dpdk-dev] [PATCH 06/11] mk: fix verbose pmdinfogen run Thomas Monjalon
2016-07-07 16:04 ` Neil Horman
2016-07-07 15:36 ` [dpdk-dev] [PATCH 07/11] pmdinfogen: fix build warnings Thomas Monjalon
2016-07-07 17:55 ` Neil Horman [this message]
2016-07-07 21:25 ` Mcnamara, John
2016-07-08 14:51 ` Neil Horman
2016-07-07 15:36 ` [dpdk-dev] [PATCH 08/11] pmdinfogen: fix usage message Thomas Monjalon
2016-07-07 16:05 ` Neil Horman
2016-07-07 16:24 ` Thomas Monjalon
2016-07-07 17:46 ` Neil Horman
2016-07-07 15:36 ` [dpdk-dev] [PATCH 09/11] eal: move PCI table macro Thomas Monjalon
2016-07-07 15:41 ` Thomas Monjalon
2016-07-07 16:11 ` Neil Horman
2016-07-07 16:25 ` Thomas Monjalon
2016-07-08 8:49 ` David Marchand
2016-07-08 13:56 ` Neil Horman
2016-07-08 14:03 ` Thomas Monjalon
2016-07-08 14:13 ` Neil Horman
2016-07-07 15:36 ` [dpdk-dev] [PATCH 10/11] doc: fix syntax in pmdinfogen guide Thomas Monjalon
2016-07-07 15:42 ` Thomas Monjalon
2016-07-07 16:12 ` Neil Horman
2016-07-07 15:36 ` [dpdk-dev] [PATCH 11/11] maintainers: add section for pmdinfo Thomas Monjalon
2016-07-07 15:45 ` Thomas Monjalon
2016-07-07 16:14 ` Neil Horman
2016-07-07 16:26 ` Thomas Monjalon
2016-07-07 16:14 ` Neil Horman
2016-07-08 10:14 ` [dpdk-dev] [PATCH v2 00/10] additions to pmdinfogen Thomas Monjalon
2016-07-08 10:14 ` [dpdk-dev] [PATCH v2 01/10] drivers: fix build with new register macro Thomas Monjalon
2016-07-08 10:14 ` [dpdk-dev] [PATCH v2 02/10] mk: fix build dependency of drivers on pmdinfogen Thomas Monjalon
2016-07-08 10:14 ` [dpdk-dev] [PATCH v2 03/10] mk: remove traces of hostapp build directory Thomas Monjalon
2016-07-08 10:14 ` [dpdk-dev] [PATCH v2 04/10] mk: fix driver build with installed SDK Thomas Monjalon
2016-07-08 10:14 ` [dpdk-dev] [PATCH v2 05/10] mk: fix verbose pmdinfogen run Thomas Monjalon
2016-07-08 10:14 ` [dpdk-dev] [PATCH v2 06/10] pmdinfogen: fix build warnings Thomas Monjalon
2016-07-08 10:14 ` [dpdk-dev] [PATCH v2 07/10] pmdinfogen: fix usage message Thomas Monjalon
2016-07-08 10:14 ` [dpdk-dev] [PATCH v2 08/10] eal: move PCI table macro Thomas Monjalon
2016-07-08 10:14 ` [dpdk-dev] [PATCH v2 09/10] doc: fix syntax in pmdinfogen guide Thomas Monjalon
2016-07-08 10:14 ` [dpdk-dev] [PATCH v2 10/10] maintainers: add section for pmdinfo Thomas Monjalon
2016-07-08 14:42 ` [dpdk-dev] [PATCH v3 00/10] additions to pmdinfogen Thomas Monjalon
2016-07-08 14:42 ` [dpdk-dev] [PATCH v3 01/10] drivers: fix build with new register macro Thomas Monjalon
2016-07-08 14:42 ` [dpdk-dev] [PATCH v3 02/10] mk: fix build dependency of drivers on pmdinfogen Thomas Monjalon
2016-07-08 14:42 ` [dpdk-dev] [PATCH v3 03/10] mk: remove traces of hostapp build directory Thomas Monjalon
2016-07-08 14:42 ` [dpdk-dev] [PATCH v3 04/10] mk: fix driver build with installed SDK Thomas Monjalon
2016-07-08 14:53 ` Neil Horman
2016-07-08 14:42 ` [dpdk-dev] [PATCH v3 05/10] mk: fix verbose pmdinfogen run Thomas Monjalon
2016-07-08 14:42 ` [dpdk-dev] [PATCH v3 06/10] pmdinfogen: fix build warnings Thomas Monjalon
2016-07-08 15:23 ` Neil Horman
2016-07-08 14:42 ` [dpdk-dev] [PATCH v3 07/10] pmdinfogen: fix usage message Thomas Monjalon
2016-07-08 15:25 ` Neil Horman
2016-07-08 14:42 ` [dpdk-dev] [PATCH v3 08/10] eal: remove PCI include from generic driver header Thomas Monjalon
2016-07-08 15:26 ` Neil Horman
2016-07-08 14:42 ` [dpdk-dev] [PATCH v3 09/10] doc: fix syntax in pmdinfogen guide Thomas Monjalon
2016-07-08 14:42 ` [dpdk-dev] [PATCH v3 10/10] maintainers: add section for pmdinfo Thomas Monjalon
2016-07-08 15:54 ` [dpdk-dev] [PATCH v3 00/10] additions to pmdinfogen Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707175527.GN26064@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).