From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Maxime Leroy <maxime.leroy@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix packet type and offload flags in Rx
Date: Fri, 8 Jul 2016 09:09:32 +0200 [thread overview]
Message-ID: <20160708070932.GY7621@6wind.com> (raw)
In-Reply-To: <1467909285-896-1-git-send-email-maxime.leroy@6wind.com>
On Thu, Jul 07, 2016 at 06:34:45PM +0200, Maxime Leroy wrote:
> In mlx5 rx function, the packet_type and ol_flags mbuf fields are not
> properly initialized when no rx offload feature is enabled (checksum, l2
> tun checksum, vlan_strip, crc). Thus, these fields can have a value
> different of 0 depending on their value when the mbuf was freed.
>
> This can result in an incorrect application behavior if invalid
> ol_flags/ptype are set, or memory corruptions if IND_ATTACHED_MBUF is
> set in ol_flags.
>
> Fixes: 081f7eae242e ("mlx5: process offload flags only when requested")
>
> Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>
> ---
> drivers/net/mlx5/mlx5_rxtx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index 0c352f3f..4132fd74 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -1599,6 +1599,8 @@ mlx5_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n)
> pkt = seg;
> assert(len >= (rxq->crc_present << 2));
> /* Update packet information. */
> + pkt->packet_type = 0;
> + pkt->ol_flags = 0;
> if (rxq->csum | rxq->csum_l2tun | rxq->vlan_strip |
> rxq->crc_present) {
> if (rxq->csum) {
> --
> 2.1.4
>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2016-07-08 7:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 16:34 Maxime Leroy
2016-07-08 7:09 ` Adrien Mazarguil [this message]
2016-07-08 20:49 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708070932.GY7621@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=maxime.leroy@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).