From: Bruce Richardson <bruce.richardson@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com,
helin.zhang@intel.com, Maxime Leroy <maxime.leroy@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: support checksum flags in sse vector Rx function
Date: Fri, 8 Jul 2016 21:42:12 +0100 [thread overview]
Message-ID: <20160708204212.GA34980@bricha3-MOBL3> (raw)
In-Reply-To: <1467893942-4048-1-git-send-email-olivier.matz@6wind.com>
On Thu, Jul 07, 2016 at 02:19:02PM +0200, Olivier Matz wrote:
> Update desc_to_olflags_v() to set PKT_RX_IP_CKSUM_BAD and
> PKT_RX_L4_CKSUM_BAD in the ol_fags of the mbuf.
>
> The Rx vector function can now be used with hw_ip_checksum
> enabled.
>
> Tested with:
>
> cd dpdk.org/
> make config T=x86_64-native-linuxapp-gcc
> make -j32
> mkdir -p /mnt/huge
> mount -t hugetlbfs nodev /mnt/huge
> echo 256 > /sys/devices/system/node/node0/hugepages/hugepages-2048kB/nr_hugepages
> modprobe uio_pci_generic
> python tools/dpdk_nic_bind.py -b uio_pci_generic 0000:04:00.0
> ./build/app/testpmd -l 2,4 -- --total-num-mbufs=65536 -i --port-topology=chained --enable-rx-cksum --disable-hw-vlan-filter --disable-hw-vlan-strip
> set fwd rxonly
> set verbose 1
> start
>
> # send packets to testpmd using scapy
> eh = Ether(src="00:01:02:03:04:05", dst="00:1B:21:AB:8F:10")
> p = Ether()/IP(src="1.1.1.1", dst="1.1.1.2")/UDP()/Raw("x"*50)
> sendp(p, iface="ixgbe2")
> p = Ether()/IP(src="1.1.1.1", dst="1.1.1.2", chksum=42)/UDP()/Raw("x"*50)
> sendp(p, iface="ixgbe2")
> p = Ether()/IP(src="1.1.1.1", dst="1.1.1.2")/UDP(chksum=42)/Raw("x"*50)
> sendp(p, iface="ixgbe2")
> p = Ether()/IP(src="1.1.1.1", dst="1.1.1.2", chksum=45)/UDP(chksum=42)/Raw("x"*50)
> sendp(p, iface="ixgbe2")
>
> # result
> port 0/queue 0: received 1 packets
> src=00:01:02:03:04:05 - dst=00:1B:21:AB:8F:10 - type=0x0800 - length=92 - nb_segs=1Unknown packet type
> - Receive queue=0x0
> port 0/queue 0: received 1 packets
> src=00:01:02:03:04:05 - dst=00:1B:21:AB:8F:10 - type=0x0800 - length=92 - nb_segs=1Unknown packet type
> - Receive queue=0x0
> PKT_RX_IP_CKSUM_BAD
> port 0/queue 0: received 1 packets
> src=00:01:02:03:04:05 - dst=00:1B:21:AB:8F:10 - type=0x0800 - length=92 - nb_segs=1Unknown packet type
> - Receive queue=0x0
> PKT_RX_L4_CKSUM_BAD
> port 0/queue 0: received 1 packets
> src=00:01:02:03:04:05 - dst=00:1B:21:AB:8F:10 - type=0x0800 - length=92 - nb_segs=1Unknown packet type
> - Receive queue=0x0
> PKT_RX_L4_CKSUM_BAD
> PKT_RX_IP_CKSUM_BAD
>
> Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
Given this looks a significant change to a complicated piece of code, which is
also very performance sensitive, I believe this change needs to be deferred to
16.11 release, as there is not enough time to properly review and test it for
16.07.
/Bruce
next prev parent reply other threads:[~2016-07-08 20:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 12:19 Olivier Matz
2016-07-08 20:42 ` Bruce Richardson [this message]
2016-07-10 17:41 ` Olivier Matz
2016-07-14 9:24 ` Chandran, Sugesh
2016-07-19 15:51 ` Olivier Matz
2016-09-14 12:39 ` Ferruh Yigit
2016-10-06 14:00 ` [dpdk-dev] " Remy Horton
2016-10-13 23:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708204212.GA34980@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=maxime.leroy@6wind.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).