From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] doc: note a pitfall on reconnect feature
Date: Wed, 20 Jul 2016 09:08:35 +0800 [thread overview]
Message-ID: <20160720010835.GO5146@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2025A310C@IRSMSX103.ger.corp.intel.com>
On Tue, Jul 19, 2016 at 01:57:11PM +0000, Mcnamara, John wrote:
> > - Note: the "reconnect" feature requires **QEMU v2.7** (or above).
> > + .. Note::
> > + * The "reconnect" feature requires **QEMU v2.7** (or above).
> > +
> > + * The vhost supported features must be exactly the same before and
> > + after the restart. For example, if TSO is disabled and then
> > enabled,
> > + nothing will work and issues undefined might happen.
>
> s/ issues undefined / undefined issues /
Thomas, mind to fix it while apply?
> Apart from that:
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Thanks!
--yliu
next prev parent reply other threads:[~2016-07-20 1:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 4:17 Yuanhan Liu
2016-07-19 4:17 ` [dpdk-dev] [PATCH RFC] maintainers: add git tree for virtio/vhost Yuanhan Liu
2016-07-22 20:39 ` Thomas Monjalon
2016-07-19 13:57 ` [dpdk-dev] [PATCH] doc: note a pitfall on reconnect feature Mcnamara, John
2016-07-20 1:08 ` Yuanhan Liu [this message]
2016-07-22 16:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160720010835.GO5146@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).